-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix linea ticker #25436
fix: fix linea ticker #25436
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@@ -662,7 +662,7 @@ export const getNonTestNetworks = createDeepEqualSelector( | |||
imageUrl: LINEA_MAINNET_TOKEN_IMAGE_URL, | |||
}, | |||
providerType: NETWORK_TYPES.LINEA_MAINNET, | |||
ticker: TEST_NETWORK_TICKER_MAP[NETWORK_TYPES.LINEA_MAINNET], | |||
ticker: CURRENCY_SYMBOLS.ETH, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the value of TEST_NETWORK_TICKER_MAP[NETWORK_TYPES.LINEA_MAINNET]
is undefined instead of ETH
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emmmm i see the selector name is getNonTestNetworks
, so it makes sense that the ticker is not from TEST_NETWORK_TICKER_MAP
. also linea mainnet
is explicitly excluded from TEST_NETWORK_TICKER_MAP
;
Doing this LGTM!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25436 +/- ##
========================================
Coverage 64.93% 64.93%
========================================
Files 1385 1385
Lines 54870 54870
Branches 14408 14408
========================================
Hits 35625 35625
Misses 19245 19245 ☔ View full report in Codecov by Sentry. |
Builds ready [351de2e]
Page Load Metrics (54 ± 6 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Description
Linea mainnet ticker should not be undefined.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist