Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix linea ticker #25436

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix: fix linea ticker #25436

merged 1 commit into from
Jun 20, 2024

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Jun 20, 2024

Description

Linea mainnet ticker should not be undefined.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to network selector and choose lieann
  2. Go back to the wallet page
  3. scam warning is displayed for Linea mainnet because ticker is undefined

Screenshots/Recordings

Before

Screenshot 2024-06-20 at 13 14 37

After

Screenshot 2024-06-20 at 13 13 22

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb requested a review from a team as a code owner June 20, 2024 11:13
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. regression-develop Regression bug that was found on development branch, but not yet present in production labels Jun 20, 2024
@@ -662,7 +662,7 @@ export const getNonTestNetworks = createDeepEqualSelector(
imageUrl: LINEA_MAINNET_TOKEN_IMAGE_URL,
},
providerType: NETWORK_TYPES.LINEA_MAINNET,
ticker: TEST_NETWORK_TICKER_MAP[NETWORK_TYPES.LINEA_MAINNET],
ticker: CURRENCY_SYMBOLS.ETH,
Copy link
Contributor Author

@salimtb salimtb Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the value of TEST_NETWORK_TICKER_MAP[NETWORK_TYPES.LINEA_MAINNET] is undefined instead of ETH

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emmmm i see the selector name is getNonTestNetworks, so it makes sense that the ticker is not from TEST_NETWORK_TICKER_MAP. also linea mainnet is explicitly excluded from TEST_NETWORK_TICKER_MAP;
Doing this LGTM!

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.93%. Comparing base (523af49) to head (351de2e).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25436   +/-   ##
========================================
  Coverage    64.93%   64.93%           
========================================
  Files         1385     1385           
  Lines        54870    54870           
  Branches     14408    14408           
========================================
  Hits         35625    35625           
  Misses       19245    19245           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [351de2e]
Page Load Metrics (54 ± 6 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6911386126
domContentLoaded9301252
load418754126
domInteractive9301252
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -34 Bytes (-0.00%)

@salimtb salimtb merged commit 9e810ee into develop Jun 20, 2024
89 of 90 checks passed
@salimtb salimtb deleted the fix-linea-mainnet-ticker branch June 20, 2024 16:15
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. regression-develop Regression bug that was found on development branch, but not yet present in production release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants