Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy changes in re-designed SIWE signature pages #25381

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jun 18, 2024

Description

copy changes in re-designed SIWE signature pages

Related issues

Fixes: #25319

Manual testing steps

  1. Enable re-designs for SIWE signature pages
  2. Open test dapp and submit SIWE signature request
  3. Check confirmation page for copy changes

Screenshots/Recordings

Screenshot 2024-06-18 at 5 53 17 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added confirmation-redesign team-confirmations Push issues to confirmations team labels Jun 18, 2024
@jpuri jpuri requested review from a team as code owners June 18, 2024 12:05
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@@ -67,7 +67,7 @@ const PersonalSignInfo: React.FC = () => {
alertKey="requestFrom"
ownerId={currentConfirmation.id}
label={t('requestFrom')}
tooltip={t('requestFromInfo')}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: we will want to include these nuances in our upcoming tests #24679

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.38%. Comparing base (da4b61c) to head (41b4c33).
Report is 1 commits behind head on develop.

Files Patch % Lines
...s/confirmations/components/confirm/title/title.tsx 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25381      +/-   ##
===========================================
- Coverage    65.38%   65.38%   -0.00%     
===========================================
  Files         1382     1382              
  Lines        54767    54772       +5     
  Branches     14368    14371       +3     
===========================================
+ Hits         35809    35812       +3     
- Misses       18958    18960       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuri jpuri merged commit 2115516 into develop Jun 19, 2024
73 checks passed
@jpuri jpuri deleted the siwe_copy_changes branch June 19, 2024 09:26
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
confirmation-redesign release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Signature Redesign] SIWE: Copy updates
4 participants