-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: @metamask/transaction-controller@^29.1.0->^30.0.0 #24861
fix: @metamask/transaction-controller@^29.1.0->^30.0.0 #24861
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
a885388
to
4da3ec0
Compare
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/network-controller@18.1.0 |
dff2780
to
cf6187c
Compare
7b44c5a
to
36b6c33
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24861 +/- ##
===========================================
- Coverage 65.71% 65.71% -0.00%
===========================================
Files 1368 1368
Lines 54388 54388
Branches 14150 14150
===========================================
- Hits 35739 35737 -2
- Misses 18649 18651 +2 ☔ View full report in Codecov by Sentry. |
d288c19
to
6bb8cee
Compare
11f7e1e
to
3bd7d28
Compare
3bd7d28
to
af52b59
Compare
af52b59
to
2f69af1
Compare
0121814
to
d08b0da
Compare
for nonce-tracker/block-tracker bump
The currently replaced versions are verified compatible. Fixes nonce-tracker issue
d08b0da
to
dc00895
Compare
3a96372
to
ec1178f
Compare
ec1178f
to
d06eb7c
Compare
Description
Updates
@metamask/transaction-controller
and@metamask/network-controller
to use latest version of@metamask/eth-block-tracker
containing fix for multiple polling loops.Updates
@metamask/network-controller
for the same and ensuring block tracker is in sync.The
nonce-tracker
patch is removed as the changes have been incorporated in the new version, which is now used consistently.Related issues
@metamask/eth-token-tracker
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist