Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Store artifacts for test-e2e-chrome-vault-decryption tests #24030

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Apr 15, 2024

… in circleci

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [788e1ba]
Page Load Metrics (958 ± 502 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint683111436029
domContentLoaded1099362311
load5523819581045502
domInteractive1099362311
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.57%. Comparing base (2cde24c) to head (788e1ba).
Report is 760 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #24030   +/-   ##
========================================
  Coverage    67.57%   67.57%           
========================================
  Files         1246     1246           
  Lines        48887    48887           
  Branches     12746    12746           
========================================
  Hits         33031    33031           
  Misses       15856    15856           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions bot added stale issues and PRs marked as stale and removed stale issues and PRs marked as stale labels Jun 14, 2024
@Gudahtt Gudahtt changed the title Adds store_artifacts step to the test-e2e-chrome-vault-decryption job… test: Store artifacts for test-e2e-chrome-vault-decryption tests Jun 20, 2024
@danjm danjm marked this pull request as ready for review June 20, 2024 11:54
@danjm danjm requested review from kumavis and a team as code owners June 20, 2024 11:54
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seaona seaona merged commit 5960ae7 into develop Jun 21, 2024
74 of 77 checks passed
@seaona seaona deleted the fix-test-artifacts-vault branch June 21, 2024 13:09
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants