Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes you've been waiting for, how exciting! #2155

Merged
merged 12 commits into from
Sep 27, 2017
Merged

Various fixes you've been waiting for, how exciting! #2155

merged 12 commits into from
Sep 27, 2017

Conversation

kumavis
Copy link
Member

@kumavis kumavis commented Sep 22, 2017

  • fix memory leak warning
  • fix filters middleware to include historical results
  • add some missing deps
  • metamaskController.blockTracker now references the actual eth-block-tracker on provider-engine

@kumavis
Copy link
Member Author

kumavis commented Sep 22, 2017

seems like a mascara test failure here

@kumavis
Copy link
Member Author

kumavis commented Sep 22, 2017

just need to make sure we're on the correct deps before build and publish
relies on correct version 4 deps deep

so lets be sure to nuke node_modules and npm i on npm@4

@2-am-zzz 2-am-zzz requested a review from frankiebee September 25, 2017 18:06
@danfinlay
Copy link
Contributor

Fixes #2122

frankiebee
frankiebee previously requested changes Sep 25, 2017
View reviewed changes
Copy link
Contributor

@frankiebee frankiebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to track event listeners and reassign them on network change for this to not cause any strange bugs

@frankiebee
Copy link
Contributor

please wrap in a proxy and catch the .on callbacks let me know if you'd like me to do that.

@kumavis
Copy link
Member Author

kumavis commented Sep 26, 2017

I DIG IT

@frankiebee frankiebee dismissed their stale review September 26, 2017 21:11
  • requirements met
@kumavis
Copy link
Member Author

kumavis commented Sep 27, 2017

@frankiebee need to actually change review to approve, not dismiss

danfinlay
danfinlay approved these changes Sep 27, 2017
View reviewed changes
Copy link
Contributor

@danfinlay danfinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursory review looks good, want to do fractional rollout. Maybe a changelog entry?

@danfinlay danfinlay merged commit 828dbd7 into master Sep 27, 2017
@danfinlay danfinlay deleted the filter-fixes-moar branch September 27, 2017 18:14
@gghidini gghidini mentioned this pull request Sep 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danfinlay danfinlay danfinlay approved these changes

@frankiebee frankiebee frankiebee left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumavis @danfinlay @frankiebee