-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(action): update fetch-depth parameter to fetch only the last commit #21119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it, rather than the whole commit history We used to fetch the whole commit history which wasn't useful for this github action. This change allows to fetch only the latest commit which makes the workflow more efficient. This improvement is not a game changer, but it's worth doing it as the workflow runs quite often (multiple times for every PR), as it's triggered every time PR labels are updated.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
13 tasks
gauthierpetetin
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Sep 29, 2023
…it (#7362) ## **Description** Update `fetch-depth` parameter to fetch only the last commit, rather than the whole commit history We used to fetch the whole commit history which wasn't useful for this github action. This change allows to fetch only the latest commit which makes the workflow more efficient. This improvement is not a game changer, but it's worth doing it as the workflow runs quite often (multiple times for every PR), as it's triggered every time PR labels are updated. Same [PR](MetaMask/metamask-extension#21119) for Extension. ## **Manual testing steps** 1. Add a team label on this PR, the job shall turn to green 2. Remove team label from this PR, the job shall turn to red ## **Screenshots/Recordings** See recording [here](MetaMask/metamask-extension#19984) ### **Before** _[screenshot]_ ### **After** _[screenshot]_ ## **Related issues** _Fixes #???_ ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained: - [x] What problem this PR is solving. - [x] How this problem was solved. - [x] How reviewers can test my changes. - [ ] I’ve indicated what issue this PR is linked to: Fixes #??? - [ ] I’ve included tests if applicable. - [x] I’ve documented any added code. - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). - [x] I’ve properly set the pull request status: - [] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
DDDDDanica
approved these changes
Sep 29, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #21119 +/- ##
========================================
Coverage 68.46% 68.46%
========================================
Files 1012 1012
Lines 40449 40449
Branches 10790 10790
========================================
Hits 27693 27693
Misses 12756 12756 ☔ View full report in Codecov by Sentry. |
Builds ready [1f1d533]
Page Load Metrics (1668 ± 486 ms)
Bundle size diffs
|
zone-live
approved these changes
Oct 3, 2023
metamaskbot
added
the
release-11.3.0
Issue or pull request that will be included in release 11.3.0
label
Oct 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.3.0
Issue or pull request that will be included in release 11.3.0
team-extension-platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
fetch-depth
parameter to fetch only the last commit, rather than the whole commit historyWe used to fetch the whole commit history which wasn't useful for this github action. This change allows to fetch only the latest commit which makes the workflow more efficient. This improvement is not a game changer, but it's worth doing it as the workflow runs quite often (multiple times for every PR), as it's triggered every time PR labels are updated.
Same PR for Mobile.
Manual testing steps
Screenshots/Recordings
See recording here
Before
[screenshot]
After
[screenshot]
Related issues
Fixes #???
Pre-merge author checklist
Pre-merge reviewer checklist