Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(action): update fetch-depth parameter to fetch only the last commit #21119

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

gauthierpetetin
Copy link
Contributor

@gauthierpetetin gauthierpetetin commented Sep 29, 2023

Description

Update fetch-depth parameter to fetch only the last commit, rather than the whole commit history

We used to fetch the whole commit history which wasn't useful for this github action. This change allows to fetch only the latest commit which makes the workflow more efficient. This improvement is not a game changer, but it's worth doing it as the workflow runs quite often (multiple times for every PR), as it's triggered every time PR labels are updated.

Same PR for Mobile.

Manual testing steps

  1. Add a team label on this PR, the job shall turn to green
  2. Remove team label from this PR, the job shall turn to red

Screenshots/Recordings

See recording here

Before

[screenshot]

After

[screenshot]

Related issues

Fixes #???

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • [] In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…it, rather than the whole commit history

We used to fetch the whole commit history which wasn't useful for this github action. This change allows to fetch only the latest commit which makes the workflow more efficient. This improvement is not a game changer, but it's worth doing it as the workflow runs quite often (multiple times for every PR), as it's triggered every time PR labels are updated.
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

gauthierpetetin added a commit to MetaMask/metamask-mobile that referenced this pull request Sep 29, 2023
…it (#7362)

## **Description**
Update `fetch-depth` parameter to fetch only the last commit, rather
than the whole commit history

We used to fetch the whole commit history which wasn't useful for this
github action. This change allows to fetch only the latest commit which
makes the workflow more efficient. This improvement is not a game
changer, but it's worth doing it as the workflow runs quite often
(multiple times for every PR), as it's triggered every time PR labels
are updated.

Same [PR](MetaMask/metamask-extension#21119) for
Extension.

## **Manual testing steps**

1. Add a team label on this PR, the job shall turn to green
2. Remove team label from this PR, the job shall turn to red

## **Screenshots/Recordings**

See recording
[here](MetaMask/metamask-extension#19984)

### **Before**

_[screenshot]_

### **After**

_[screenshot]_

## **Related issues**

_Fixes #???_

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained:
  - [x] What problem this PR is solving.
  - [x] How this problem was solved.
  - [x] How reviewers can test my changes.
- [ ] I’ve indicated what issue this PR is linked to: Fixes #???
- [ ] I’ve included tests if applicable.
- [x] I’ve documented any added code.
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
- [x] I’ve properly set the pull request status:
  - [] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5edceb2) 68.46% compared to head (1f1d533) 68.46%.
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21119   +/-   ##
========================================
  Coverage    68.46%   68.46%           
========================================
  Files         1012     1012           
  Lines        40449    40449           
  Branches     10790    10790           
========================================
  Hits         27693    27693           
  Misses       12756    12756           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [1f1d533]
Page Load Metrics (1668 ± 486 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1061881372010
domContentLoaded881771252311
load102254716681013486
domInteractive881771252311
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@gauthierpetetin gauthierpetetin merged commit fb8d018 into develop Oct 3, 2023
@gauthierpetetin gauthierpetetin deleted the fix/action-check-pr-labels branch October 3, 2023 14:50
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants