Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of #18714: Replace deprecated design system typography consts with enums in:custody-labels.js #19038

Conversation

dhruvv173
Copy link
Contributor

Explanation

This PR is a part of #18714
Replaced deprecated design system typography consts with enums in custody-labels.js

  • ui/components/institutional/custody-labels.js

Screenshots/Screencaps

Before

image

After

image

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@dhruvv173 dhruvv173 requested a review from a team as a code owner May 6, 2023 15:56
@dhruvv173 dhruvv173 requested a review from danjm May 6, 2023 15:56
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dhruvv173 dhruvv173 changed the title Replace deprecated design system typography consts with enums in:custody-labels.js Part of #18714: Replace deprecated design system typography consts with enums in:custody-labels.js May 6, 2023
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label May 6, 2023
@darkwing
Copy link
Contributor

darkwing commented May 8, 2023

Thank you for this contribution @dhruvv173 !

@darkwing darkwing merged commit c4e7b55 into MetaMask:develop May 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2023
@dhruvv173 dhruvv173 deleted the Part-of-#18714-Replace-deprecated-design-system-typography-consts-with-enums-incustody-labels branch July 25, 2023 10:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants