Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of #17670: Replace Typography with Text component #18569

Merged
merged 4 commits into from
Apr 24, 2023

Conversation

omraval18
Copy link
Contributor

Explanation

Updating <Typography/> to <Text/> in ui/pages/swaps/smart-transaction-status/smart-transaction-status.js

Screenshots/Screencaps

Before

Opera Snapshot_2023-04-13_155640_localhost

After

Opera Snapshot_2023-04-13_160842_localhost

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@omraval18 omraval18 requested a review from a team as a code owner April 13, 2023 11:32
@omraval18 omraval18 requested a review from danjm April 13, 2023 11:32
@github-actions
Copy link
Contributor

github-actions bot commented Apr 13, 2023

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you all read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

1 out of 2 committers have signed the CLA.
@omraval18
@Om Raval

GitHub can't find an account for Om Raval.
You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@omraval18
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@brad-decker
Copy link
Contributor

Hey there @omraval18 your first commit (the one you authored locally, versus the one you made via github UI) is under a different username which is why the CLA is failing. If you want to resolve this you'd need to set your git user email to your github email and then rebase your PR on develop. The new commit that creates will be attributed to your github username. https://stackoverflow.com/questions/28141653/does-user-name-in-git-need-to-match-my-github-username

@omraval18
Copy link
Contributor Author

@brad-decker thanks I'll look into it!

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Apr 19, 2023
@omraval18 omraval18 closed this Apr 23, 2023
@omraval18 omraval18 reopened this Apr 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2023
Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NidhiKJha NidhiKJha merged commit 1452a5a into MetaMask:develop Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants