-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make eth_accounts
return all permitted accounts
#18516
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [2d198a1]
Page Load Metrics (1428 ± 39 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
…most recently selected one
…st the most recently selected one
rekmarks
force-pushed
the
return-all-permitted-accounts
branch
from
April 9, 2023 18:11
2d198a1
to
391255e
Compare
Builds ready [391255e]
Page Load Metrics (1673 ± 85 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [4c506b6]
Page Load Metrics (1579 ± 50 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [72c8974]
Page Load Metrics (1517 ± 34 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
@vandan to add a developer comms plan for this update. |
Needs corresponding Mobile PR. |
3 tasks
Accidentally deleted branch |
I have read the CLA Document and I hereby sign the CLA |
Builds ready [4d659bd]
Page Load Metrics (1693 ± 79 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
|
BelfordZ
approved these changes
Jun 8, 2023
Builds ready [0bf8327]
Page Load Metrics (1507 ± 34 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
shanejonas
approved these changes
Jun 8, 2023
gauthierpetetin
added
type-bug
regression-RC
DEPRECATED: Please use "regresssion-RC-x.y.z" label instead
release-5.11.0
and removed
type-bug
regression-RC
DEPRECATED: Please use "regresssion-RC-x.y.z" label instead
release-5.11.0
labels
Jun 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
It's high time we make
eth_accounts
return all permitted accounts instead of only the most recently selected one, just like the inventors of arrays intended. There are no associated UI changes. See #18515 for details.Fixes #18515
Manual Testing Steps
This change should not affect any functionality within the extension, but may cause unexpected breakages in dapps. We should conduct basic compatibility testing with our own e2e test dapp and the top X currently used dapps in MetaMask. We should consider shipping this change to Mobile at the same time.
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.