Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make eth_accounts return all permitted accounts #18516

Merged
merged 8 commits into from
Jun 8, 2023

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Apr 8, 2023

Explanation

It's high time we make eth_accounts return all permitted accounts instead of only the most recently selected one, just like the inventors of arrays intended. There are no associated UI changes. See #18515 for details.

Fixes #18515

Manual Testing Steps

This change should not affect any functionality within the extension, but may cause unexpected breakages in dapps. We should conduct basic compatibility testing with our own e2e test dapp and the top X currently used dapps in MetaMask. We should consider shipping this change to Mobile at the same time.

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@metamaskbot
Copy link
Collaborator

Builds ready [2d198a1]
Page Load Metrics (1428 ± 39 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint85143102167
domContentLoaded1303159814217737
load1303159814288239
domInteractive1303159814217737
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -11 bytes
  • ui: 0 bytes
  • common: 0 bytes

@rekmarks rekmarks force-pushed the return-all-permitted-accounts branch from 2d198a1 to 391255e Compare April 9, 2023 18:11
@metamaskbot
Copy link
Collaborator

Builds ready [391255e]
Page Load Metrics (1673 ± 85 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint912001193115
domContentLoaded14192031165717885
load14412045167317785
domInteractive14192031165717885
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -11 bytes
  • ui: 0 bytes
  • common: 0 bytes

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [4c506b6]
Page Load Metrics (1579 ± 50 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint901761112311
domContentLoaded14071797156010249
load14071808157910550
domInteractive14071797156010249
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -11 bytes
  • ui: 0 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [72c8974]
Page Load Metrics (1517 ± 34 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint91154105147
domContentLoaded1393162414946531
load1401162815177034
domInteractive1393162414946531
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -11 bytes
  • ui: 0 bytes
  • common: 0 bytes

@vandan
Copy link

vandan commented Apr 18, 2023

@vandan to add a developer comms plan for this update.

@vandan
Copy link

vandan commented Apr 18, 2023

Needs corresponding Mobile PR.

@jiexi jiexi closed this May 30, 2023
@jiexi jiexi deleted the return-all-permitted-accounts branch May 30, 2023 21:49
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2023
@jiexi jiexi restored the return-all-permitted-accounts branch May 30, 2023 21:52
@jiexi
Copy link
Contributor

jiexi commented May 30, 2023

Accidentally deleted branch

@jiexi jiexi reopened this May 30, 2023
@jiexi jiexi marked this pull request as ready for review June 6, 2023 21:43
@jiexi jiexi requested a review from a team as a code owner June 6, 2023 21:43
@jiexi jiexi requested review from DDDDDanica and removed request for DDDDDanica June 6, 2023 21:43
@jiexi
Copy link
Contributor

jiexi commented Jun 7, 2023

I have read the CLA Document and I hereby sign the CLA

@metamaskbot
Copy link
Collaborator

Builds ready [4d659bd]
Page Load Metrics (1693 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1003131334723
domContentLoaded14822070165815172
load14832183169316579
domInteractive14822070165815172
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -11 bytes
  • ui: 0 bytes
  • common: 0 bytes

@jiexi
Copy link
Contributor

jiexi commented Jun 8, 2023

Needs corresponding Mobile PR.

Mobile PR here

@metamaskbot
Copy link
Collaborator

Builds ready [0bf8327]
Page Load Metrics (1507 ± 34 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint95149115168
domContentLoaded1364163314966833
load1364165115077134
domInteractive1364163314966833
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -11 bytes
  • ui: 0 bytes
  • common: 0 bytes

@jiexi jiexi merged commit 9830b14 into develop Jun 8, 2023
@jiexi jiexi deleted the return-all-permitted-accounts branch June 8, 2023 20:01
@gauthierpetetin gauthierpetetin added type-bug regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-5.11.0 and removed type-bug regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-5.11.0 labels Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth_accounts should return all permitted accounts
8 participants