Fixes 'yarn start' on Windows - LavaPack is not defined (#13318) #16550

HowardBraham · 2022-11-17T04:27:19Z

Fixes #13318, Fixes #13793, Fixes #14984, and Fixes #15237
Discussed with @kumavis and @danjm
Please let me know if this breaks another system and a more complicated fix is necessary.

Update 11/18/2022: Also adds a getPathInsideNodeModules helper function to end reliance on writing paths that start with ./node_modules/

github-actions · 2022-11-17T04:27:31Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2022-11-17T13:47:24Z

Builds ready [6dd73eb]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2351 ± 213 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	93	1105	174	215	103
		domContentLoaded	1699	3934	2314	447	215
		load	1740	3934	2351	444	213
		domInteractive	1699	3934	2314	447	215

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

legobeat

Can not speak for Windows. Does not break anything on Linux.

matthewwalsh0 · 2022-11-18T15:15:36Z

Not certain if it's the same issue, but I hit a similar error building on Windows previously and resolved it by updating the copy paths before they reached fast-glob.

async function copyGlob(baseDir, srcGlob, dest) {
    const fixedSrcGlob =
      process.platform === 'win32' ? srcGlob.replace(/\\/gu, '/') : srcGlob;

    const sources = await glob(fixedSrcGlob, { onlyFiles: false });

    await Promise.all(
      sources.map(async (src) => {
        const relativePath = path.relative(baseDir, src);
        await fs.copySync(src, `${dest}${relativePath}`);
      }),
    );
  }

metamaskbot · 2022-11-18T23:47:12Z

Builds ready [3ed04f1]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2352 ± 83 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	96	2486	236	517	248
		domContentLoaded	1951	2580	2317	165	79
		load	1970	2624	2352	174	83
		domInteractive	1951	2580	2317	165	79

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

development/build/utils.js

legobeat · 2022-11-19T01:44:57Z

development/build/utils.js

+  targetPath += pathToFiles;
+
+  if (process.platform === 'win32') {
+    targetPath = targetPath.replace(/\\/gu, '/');


Would path.normalize be helpful here?

Also path.sep

path.normalize, or even path.posix.normalize will not work for this. Here's a discussion about it: nodejs/node#12298

I replaced with the following and pushed a new commit
targetPath.split(path.sep).join(path.posix.sep)

development/build/static.js

legobeat

One minor thing, LGTM otherwise!

metamaskbot · 2022-11-21T18:59:50Z

Builds ready [1313746]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2184 ± 116 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	94	240	117	31	15
		domContentLoaded	1677	2579	2166	241	116
		load	1677	2579	2184	242	116
		domInteractive	1677	2579	2166	241	116

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

Also adds a getPathInsideNodeModules helper function to end reliance on writing paths that start with './node_modules/'

metamaskbot · 2022-11-21T19:44:04Z

Builds ready [cbe45ac]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2222 ± 121 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	96	2048	216	420	202
		domContentLoaded	1737	2565	2208	232	112
		load	1737	2639	2222	251	121
		domInteractive	1737	2565	2208	232	112

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

metamaskbot · 2022-11-23T09:29:35Z

Builds ready [f237fb8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2175 ± 138 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	91	2211	223	457	219
		domContentLoaded	1597	2717	2146	301	144
		load	1674	2717	2175	288	138
		domInteractive	1597	2717	2146	301	144

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1722 bytes
ui: 17 bytes
common: 94 bytes

jpuri · 2022-11-30T05:28:41Z

I tested the PR on mac and yarn start works well 👍

Gudahtt

LGTM!

HowardBraham requested review from a team and kumavis as code owners November 17, 2022 04:27

HowardBraham requested a review from hmalik88 November 17, 2022 04:27

legobeat previously approved these changes Nov 18, 2022

View reviewed changes

HowardBraham dismissed stale reviews from legobeat and ghost via 3ac7ae6 November 18, 2022 23:00

HowardBraham force-pushed the fix/13318-lavapack-is-not-defined branch 2 times, most recently from 3ac7ae6 to 3ed04f1 Compare November 18, 2022 23:15

legobeat reviewed Nov 19, 2022

View reviewed changes

development/build/utils.js Outdated Show resolved Hide resolved

legobeat reviewed Nov 19, 2022

View reviewed changes

HowardBraham force-pushed the fix/13318-lavapack-is-not-defined branch from da3ea54 to 3b5ec18 Compare November 19, 2022 22:58

legobeat reviewed Nov 21, 2022

View reviewed changes

development/build/static.js Outdated Show resolved Hide resolved

legobeat approved these changes Nov 21, 2022

View reviewed changes

legobeat previously approved these changes Nov 21, 2022

View reviewed changes

HowardBraham dismissed legobeat’s stale review via 1313746 November 21, 2022 18:23

HowardBraham added 3 commits November 21, 2022 11:08

Fixes 'yarn start' on Windows - LavaPack is not defined (#13318)

e50f193

Also adds a getPathInsideNodeModules helper function to end reliance on writing paths that start with './node_modules/'

Implementing legobeat's suggestions, modified slightly

658780e

added a trailing slash

cbe45ac

HowardBraham force-pushed the fix/13318-lavapack-is-not-defined branch from 1313746 to cbe45ac Compare November 21, 2022 19:08

HowardBraham requested a review from legobeat November 22, 2022 18:08

legobeat approved these changes Nov 23, 2022

View reviewed changes

Merge branch 'develop' into fix/13318-lavapack-is-not-defined

f237fb8

HowardBraham added the team-accounts label Nov 23, 2022

HowardBraham removed the team-accounts label Nov 23, 2022

HowardBraham assigned matthewwalsh0 and Gudahtt Nov 23, 2022

Gudahtt approved these changes Nov 30, 2022

View reviewed changes

brad-decker merged commit b1fd7f7 into develop Nov 30, 2022

brad-decker deleted the fix/13318-lavapack-is-not-defined branch November 30, 2022 15:19

github-actions bot locked and limited conversation to collaborators Nov 30, 2022

HowardBraham added the team-accounts label Dec 1, 2022

HowardBraham unassigned Gudahtt and matthewwalsh0 Dec 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes 'yarn start' on Windows - LavaPack is not defined (#13318) #16550

Fixes 'yarn start' on Windows - LavaPack is not defined (#13318) #16550

HowardBraham commented Nov 17, 2022 •

edited

Loading

github-actions bot commented Nov 17, 2022 •

edited

Loading

metamaskbot commented Nov 17, 2022

legobeat left a comment

matthewwalsh0 commented Nov 18, 2022

metamaskbot commented Nov 18, 2022

legobeat Nov 19, 2022

HowardBraham Nov 19, 2022

legobeat left a comment

metamaskbot commented Nov 21, 2022

metamaskbot commented Nov 21, 2022

metamaskbot commented Nov 23, 2022

jpuri commented Nov 30, 2022

Gudahtt left a comment

Fixes 'yarn start' on Windows - LavaPack is not defined (#13318) #16550

Fixes 'yarn start' on Windows - LavaPack is not defined (#13318) #16550

Conversation

HowardBraham commented Nov 17, 2022 • edited Loading

github-actions bot commented Nov 17, 2022 • edited Loading

metamaskbot commented Nov 17, 2022

legobeat left a comment

Choose a reason for hiding this comment

matthewwalsh0 commented Nov 18, 2022

metamaskbot commented Nov 18, 2022

legobeat Nov 19, 2022

Choose a reason for hiding this comment

HowardBraham Nov 19, 2022

Choose a reason for hiding this comment

legobeat left a comment

Choose a reason for hiding this comment

metamaskbot commented Nov 21, 2022

metamaskbot commented Nov 21, 2022

metamaskbot commented Nov 23, 2022

jpuri commented Nov 30, 2022

Gudahtt left a comment

Choose a reason for hiding this comment

HowardBraham commented Nov 17, 2022 •

edited

Loading

github-actions bot commented Nov 17, 2022 •

edited

Loading