Fix build script errors #15493
Merged
Fix build script errors #15493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
There is a SES bug that results in errors being printed to the console
as `{}`[1]. The known workaround is to print the error stack rather
than printing the error directly. This affects our build script when it
is run with LavaMoat.
We used this workaround in one place in the build script already, but
not in the handler for task errors. We now use it in both places.
The workaround has been moved to a function that we can use throughout
the build script.
[1]: endojs/endo#944
Gudahtt
force-pushed
the
fix-build-script-errors
branch
from
6702839 to
e37b756
Compare
Builds ready [e37b756]
Page Load Metrics (1879 ± 120 ms)
|
darkwing
approved these changes
Aug 5, 2022
digiwand
approved these changes
Aug 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a SES bug that results in errors being printed to the console as
{}. The known workaround is to print the error stack rather than printing the error directly. This affects our build script when it is run with LavaMoat.We used this workaround in one place in the build script already, but not in the handler for task errors. We now use it in both places.
The workaround has been moved to a function that we can use throughout the build script.
Manual Testing Steps
yarn dist).Pre-Merge Checklist
+ If there are functional changes: