Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow advanced inline gas editing when there is an estimates unavailable error #11859

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Aug 17, 2021

This PR fixes an issue found by @PeterYinusa when QAing v10.0.2

It ensures that if estimates from our api are not available, the user is able to do inline editing in the advanced gas popover.

Screenshot from 2021-08-17 10-41-33

@danjm danjm requested a review from a team as a code owner August 17, 2021 13:12
@danjm danjm requested a review from NiranjanaBinoy August 17, 2021 13:12
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [7843129]
Page Load Metrics (688 ± 25 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint548465105
domContentLoaded6238106855124
load6248126885325
domInteractive6238106845124

@PeterYinusa
Copy link
Contributor

LGTM!

Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danaikhamkao721

This comment has been minimized.

@danjm danjm merged commit 84036aa into develop Aug 17, 2021
@danjm danjm deleted the inline-edit-when-no-estimates branch August 17, 2021 19:25
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants