Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unnecessary console log from the preferences controller #11828

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Aug 13, 2021

The error was already being logged via log.debug

@ryanml ryanml self-assigned this Aug 13, 2021
@ryanml ryanml requested a review from a team as a code owner August 13, 2021 06:05
@ryanml ryanml requested a review from NiranjanaBinoy August 13, 2021 06:05
@ryanml ryanml changed the title Removing unecessary log from the preferences controller Removing unnecessary console log from the preferences controller Aug 13, 2021
@metamaskbot
Copy link
Collaborator

Builds ready [00b8a8d]
Page Load Metrics (625 ± 21 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint51876394
domContentLoaded5387356244421
load5397366254421
domInteractive5387356244421

@ryanml ryanml merged commit 5cbece9 into develop Aug 17, 2021
@ryanml ryanml deleted the remove-log branch August 17, 2021 08:56
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants