Replace incoming with external transactions

[PatrykLucka]

Fixes: #505 #7452

Explanation:

1. IncomingTransactionsController has been replaced with ExternalTransactionsController
2. showIncomingTransactions feature flag has been changed to showExternalTransactions
3. ExternalTransactionsController now does not filter out outgoing transactions
4. New transactions type SENT has been added, wich is described as "External Send" transaction
5. _normalizeTxFromEtherscan sets the new transaction type SENT when address of the sender is the same as the one passed as the parameter

Manual testing steps:

• Import account using private key
• Use the same private key to import it to other instance of MM or any other wallet
• Send transaction using 2nd wallet
• Wait for the block request in 1st MM instance
• Check if "External Send" transaction will show up

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[brad-decker]

There's some more nuances here that we have to figure out before this can merge in. First off we currently trim transaction history of the metamask originated transactions to 50 transactions while there is no such cap for this controller. Removing the filter on which transactions it considers could result in new behavior never before seen in the extension. For example, given that the UI groups transactions by nonce, and relies on the history object of our transaction state for displaying the history, throwing in new transactions that do not have that key into the mix could be potentially confusing. Further more transactions sent from outside of MetaMask could potentially confuse the UI. Consider a transaction that is initiated and fails before being submitted, it'll have a nonce associated with it. It becomes the "primary" transaction for informing the UI what occurred. We then bring in a transaction remotely, issued from outside of MetaMask, that shares the same nonce. The status of the transaction will change in the UI but the title and the details of the transaction do not. We have this problem today, adding in outside sources will further complicate the issue.

I have some inflight work preparing for EIP-1559 and others that will change the way transactions are grouped and I think that is the appropriate time to consider this and incorporate it into that work.

[brad-decker]

The type parameter here will not be this simple, this could be any currently supported type of transaction not just sent or incoming. In the main transaction controller we use a method that determines what the transaction's type is.. we could potentially reuse some of that logic.

[Gudahtt]

Moving this into draft until we complete the aforementioned work

[brad-decker]

Hey @PatrykLucka, i'm going to close this PR. We definitely want this work, but as stated before a large amount of effort is needed to modify how we group transactions so that we can effectively handle transactions from clients outside of MetaMask. I have added a comment to #505 which is the issue originally describing this problem.