-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to ETH as primary currency on Confirm screen and allow toggle #4510
Comments
TY for the redirect @bdresser, To add some color to what I said in #25, the problem with the "Fiat first" UI is twofold.
The expected behavior is Primary: Actual token being spent / Secondary: Preferred conversion currency |
@kingjacob as with many product choices, this comes down to the question of who we're optimizing for. Much of the feedback we get comes from technical folks who understand how to get in touch. Predictably, many of these users are much more comfortable thinking in ETH values. But MetaMask is also an on-ramp for hundreds of thousands of non-technical users, for whom seeing a converted fiat value may be a key component that makes the software usable and familiar. For now, I think it makes sense to include this as a toggle in the "Settings" menu. Worth noting that ETH is the primary value for most of the application (the "Home" screen, the "Send" screen, etc) and the only place where fiat/converted currency dominates is on the "Confirm" screen. I'd like to bounty the small feature to add a toggle that swaps ETH / USD (or whatever the user's selected currency conversion is) on the Confirm screen. Everything else in the extension stays the same. make sense @danfinlay @cjeria ? |
I feel like above all else, the UI should be consistent. Having the confirmation screen default to converted as primary while the rest of the UI has ETH as the primary definitely feels wrong to me. I support an option in settings that lets the user decide Native vs Converted as the primary currency, but this should consistently effect the entire UI, not just one or two screens of the UI. |
This makes a lot of sense. I agree we need to be consistent with displaying ETH as the primary value and also provide the option to switch the primary currency globally in settings. |
Consistency is good 😄 As discussed, this should be the subject of some intentional user research as soon as we have the bandwidth. For now @cjeria are you comfortable switching to an ETH-primary view on the Confirm screen by default, and adding a toggle in settings to swap the "primary" currency across all screens? (cc @danfinlay @alextsg @danjm) |
Yes, let's default to ETH and provide a way to swap the main currency in settings. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 0.25 ETH (69.39 USD @ $277.56/ETH) attached to it.
|
Issue Status: 1. Open 2. Cancelled Work has been started. These users each claimed they can complete the work by 11 months, 3 weeks from now.
Learn more on the Gitcoin Issue Details page. |
@Rohithzr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
@bdresser yes I am working on this issue, just a bit of festive weekend in my country, Ill be back tomorrow and hopefully a PR in a couple of days. I am figuring out a few things, currently the the settings that I am selecting from the dropdown are not getting persisted, if someone has any ideas about it, that would be helpful |
- dropdown css will now adjust to shorter heights (max-height: 220px) - added option to select primary currency in settings (issue MetaMask#4510)
@bdresser This is still WIP but I wanted the UI to be looked at and confirmed as much as possible. |
@Rohithzr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
I can't even think of why anyone working in blockchain/crypto space comes up with the idea to display a (random) FIAT currency in BIG LETTERS within a software which is meant to be used to transfer Ethereum. It's all about ETH. There is ETH in the account, users want to send ETH, Gas is derived from ETH, ... it has nothing to do with any FIAT currency. This is the worst UI decision I have seen in this space so far, and I would just ignore it if it hadn't been done in one of the most prominent user facing software in blockchain space. |
@Rohithzr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
hey @Rohithzr looks like there's still a ways to go and we're hoping to get this functionality out quite soon, so we're going to handle it internally. Thanks for your work! |
Issue Status: 1. Open 2. Cancelled The funding of 0.25 ETH (72.27 USD @ $289.07/ETH) attached to this issue has been cancelled by the bounty submitter
|
We ultimately agree with you, will be changing it back, and this is one reason this is a beta UI, and not our default UI yet. The thought was of course about minimizing onboarding friction. There is a ton to learn for new users in this space, so we are constantly exploring which protocol-specific information can be postponed for new users, but we mostly agree that ultimately postponing teaching the primary unit of the protocol creates more friction than it alleviates. I wouldn't be surprised if other wallets come along, make fiat their primary conversion, and create a smoother on-boarding experience, but if that works it will probably be in part because prices have stabilized and gas prices are kept low because of scaling strategies. |
If you want to on-board new "non-technical" user (= making them familiar with Ethereum) , the first thing they have to get familiar with and to learn is, that the currency here, within the Ethereum network, is called ETH and that is the currency of value we are working with here. That is not more "difficult" than to understand that if you leave the US behind and travel to Europe that within that space "EUR" is the currency. |
From what I have read, Joe is putting 100+ million USD in per year to make the Ethereum ecosystem successful as an alternative to the current (FIAT based) financial system, and one of the first apps a new user will likely use shows "USD" in big letters ???? |
thanks for the feedback @SvenMeyer! We prioritize having a stable, usable extension first and foremost. Your viewpoint as someone familiar with Ethereum is just one of many perspectives – it's impossible and unrealistic (not to mention exclusionary) to think that personal intuition is the best answer to the many design & usability questions that come up! If your comments are based in quantitative or qualitative research, we would love to hear more about your findings - email support@metamask.io and mention this issue number. If not, we'll incorporate your design feedback along with other individual pieces of feedback we receive, and thanks for speaking up! |
A good read on this topic on the underlying motivation ... although I still see some value to display FIAT as a reference in small letters (!), just as a x-check and to avoid that inexperienced users are unintentionally transferring random amounts ... but eventually (when people have a better "feeling" about ETH value) it should totally go away. |
There has been some very good feedback from community members and it's basically being ignored because we are...biased? How about this. I have used MetaMask for ages now, today I sent this transaction: This is absurdI understand having options for fiat, I completely disagree in this case.
I completely agree with this statement. How is it acceptable to roll out an update that changes my settings? Sure, install Metamask and have new defaults, but I have always used ETH as my default currency, and some random deployment that I couldn't control changed my settings, resulting in a transaction I did not intend to send. Let's be thankful it was for less than the intended amount, can you imagine the outrage if something changed the other way? Problems like this give more fuel to the case to move over to Scatter... |
Hey @grahamPegNetwork , thanks for the feedback. The intention of this change was to allow users to have a toggle to switch between displaying ETH and Fiat based on their own preferences. It was also intended to have ETH be the default, but there was likely a bug with the migration during the update that caused the preference to default to Fiat. However, this only affects the display of the currency. Nothing about the actual transaction has changed - the UI just does a conversion to your selected Fiat currency based on the preference. Hope that clears things up. |
Thanks for the clarification, the problem I had is that it did affect my transaction, to a certain extent. As previously mentioned, I've been using MM for ages, and today I (somewhat blindly) entered "0.1" and clicked submit (also trusting that gas was reasonable). Half an hour later a colleague said I only sent them ten cents. (See the transaction linked) "the UI just does a conversion to your selected Fiat currency based on the preference. Hope that clears things up." |
@grahamPegNetwork Yep I totally understand where you're coming from, and it's definitely frustrating to have to go through that. My point was that it was a bug during the update that led to your fields getting switched up, and that the change was unintentional. What should have happened was to default to ETH for new installs, and keep the existing preference for an update. |
Okay. Thanks for the input there @alextsg . Hope to avoid bugs like this in the future! |
Bounty: We want to update the Confirm screen to display ETH as the primary (large) value and the user's selected converted currency as the secondary (smaller) value. This feature also requires adding a toggle to the settings menu to allow users to swap the two.
--
Some users prefer to focus on their ETH balance rather than the equivalent fiat value. Right now our UI prioritizes fiat value and includes exact ETH amounts; we should consider an option that allows the user to at least swap the two.
See comments below for more detail and a complete spec.
The text was updated successfully, but these errors were encountered: