Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate components to TS: ButtonBase #18886

Closed
georgewrmarshall opened this issue Apr 29, 2023 · 1 comment · Fixed by #20060
Closed

Migrate components to TS: ButtonBase #18886

georgewrmarshall opened this issue Apr 29, 2023 · 1 comment · Fixed by #20060
Assignees
Labels
release-10.36.0 Issue or pull request that will be included in release 10.36.0 team-design-system All issues relating to design system in Extension

Comments

@georgewrmarshall
Copy link
Contributor

georgewrmarshall commented Apr 29, 2023

Description

Migrate ButtonBase component in ui/components/component-library to TypeScript

Dependencies

Technical Details

  • Convert Objects in SNAKE_CASE to enums in PascalCase (name and keys)
  • Ensure enums use singular not plural e.g. Size not Sizes
  • Update file name from component-name.contants.js to component-name.types.ts and add types
  • Update file name from component-name.js to component-name.tsx and add types
  • Update file name from component-name.test.js to component-name.test.tsx
  • Update file name from component-name.stories.js to component-name.stories.tsx
  • Update all instances of component objects to enums
  • Update all documentation

Acceptance Criteria

  • Component has been converted to TypeScript
  • Stories, documentation and tests have been updated inside of the component-name folder
  • Before/After screen cast of component stories in storybook to show no visual regression after migration

Difficulty: Intermediate

Good first issue for: External contributors who are familiar with TypeScript and want to contribute to improving the stability of the extension

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Apr 29, 2023
thebinij added a commit to thebinij/metamask-extension that referenced this issue May 2, 2023
thebinij added a commit to thebinij/metamask-extension that referenced this issue May 2, 2023
thebinij added a commit to thebinij/metamask-extension that referenced this issue May 5, 2023
thebinij added a commit to thebinij/metamask-extension that referenced this issue May 5, 2023
@thebinij thebinij mentioned this issue May 9, 2023
6 tasks
@georgewrmarshall georgewrmarshall added the good first issue Good for newcomers label May 12, 2023
@georgewrmarshall georgewrmarshall removed the good first issue Good for newcomers label Jun 5, 2023
@georgewrmarshall
Copy link
Contributor Author

Removing good-first-issue label until we close the Box dependency #19239

@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-10.36.0 Issue or pull request that will be included in release 10.36.0 team-design-system All issues relating to design system in Extension
Projects
None yet
3 participants