address feedback

MetaMask · Aug 19, 2024 · 7e14394 · 7e14394
1 parent 2321c8c
commit 7e14394
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 6 deletions.
diff --git a/test/e2e/tests/confirmations/transactions/erc721-approve-redesign.spec.ts b/test/e2e/tests/confirmations/transactions/erc721-approve-redesign.spec.ts
@@ -20,7 +20,7 @@ describe('Confirmation Redesign ERC721 Approve Component', function () {
   const smartContract = SMART_CONTRACTS.NFTS;
 
   describe('Submit an Approve transaction @no-mmi', function () {
-    it('Sends a contract interaction type 0 transaction (Legacy)', async function () {
+    it('Sends a type 0 transaction (Legacy)', async function () {
       await withFixtures(
         {
           dapp: true,
@@ -51,7 +51,7 @@ describe('Confirmation Redesign ERC721 Approve Component', function () {
       );
     });
 
-    it('Sends a contract interaction type 2 transaction (EIP1559)', async function () {
+    it('Sends a type 2 transaction (EIP1559)', async function () {
       await withFixtures(
         {
           dapp: true,

diff --git a/...snapshots__/approve-details.test.tsx.snap → ...snapshots__/approve-details.test.tsx.snap b/...snapshots__/approve-details.test.tsx.snap → ...snapshots__/approve-details.test.tsx.snap
diff --git a/...prove-details/approve-details.stories.tsx → ...prove-details/approve-details.stories.tsx b/...prove-details/approve-details.stories.tsx → ...prove-details/approve-details.stories.tsx
diff --git a/.../approve-details/approve-details.test.tsx → .../approve-details/approve-details.test.tsx b/.../approve-details/approve-details.test.tsx → .../approve-details/approve-details.test.tsx
diff --git a/...hared/approve-details/approve-details.tsx → ...prove/approve-details/approve-details.tsx b/...hared/approve-details/approve-details.tsx → ...prove/approve-details/approve-details.tsx
@@ -9,12 +9,12 @@ import { ConfirmInfoSection } from '../../../../../../../components/app/confirm/
 import { useI18nContext } from '../../../../../../../hooks/useI18nContext';
 import { selectConfirmationAdvancedDetailsOpen } from '../../../../../selectors/preferences';
 import { useDecodedTransactionData } from '../../hooks/useDecodedTransactionData';
-import { Container } from '../transaction-data/transaction-data';
+import { Container } from '../../shared/transaction-data/transaction-data';
 import {
   MethodDataRow,
   OriginRow,
   RecipientRow,
-} from '../transaction-details/transaction-details';
+} from '../../shared/transaction-details/transaction-details';
 
 const Spender = () => {
   const t = useI18nContext();
@@ -31,10 +31,12 @@ const Spender = () => {
     return null;
   }
 
+  const spender = value.data[0].params[0].value;
+
   return (
     <>
       <ConfirmInfoRow label={t('spender')} tooltip={t('spenderTooltipDesc')}>
-        <ConfirmInfoRowAddress address={value.data[0].params[0].value} />
+        <ConfirmInfoRowAddress address={spender} />
       </ConfirmInfoRow>
 
       <ConfirmInfoRowDivider />

diff --git a/ui/pages/confirmations/components/confirm/info/approve/approve.tsx b/ui/pages/confirmations/components/confirm/info/approve/approve.tsx
@@ -4,7 +4,7 @@ import { useSelector } from 'react-redux';
 import { currentConfirmationSelector } from '../../../../../../selectors';
 import { selectConfirmationAdvancedDetailsOpen } from '../../../../selectors/preferences';
 import { AdvancedDetails } from '../shared/advanced-details/advanced-details';
-import { ApproveDetails } from '../shared/approve-details/approve-details';
+import { ApproveDetails } from './approve-details/approve-details';
 import { GasFeesSection } from '../shared/gas-fees-section/gas-fees-section';
 
 const ApproveInfo = () => {