Skip to content

Commit

Permalink
test: MMQA-188: remove mmi e2e tests from ci (#29233)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

MMI e2e tests are not longer maintained so they need to be removed from
ci:

- Remove CI (only this in this PR due to the urgency of the change)

Create a new PR to remove the next points:
- Remove Docs
- **node dependencies**
- Remove e2e/tests
- Remove e2e/tests/playwright
- Remove references in scripts
- Remove stuff not in the code base like
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/116332/workflows/e18a49f4-f111-4728-abc8-23d46b93feb6/jobs/4357634

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29233?quickstart=1)

Fixes:

1. Go to this page...
2.
3.

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
racitores authored and dbrans committed Jan 15, 2025
1 parent 317a69c commit 3fe78b1
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
3 changes: 0 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1349,9 +1349,6 @@ jobs:
- run:
name: Publish Flask MV2 release to Sentry
command: yarn sentry:publish --build-type flask --dist mv2
- run:
name: Publish MMI release to Sentry
command: yarn sentry:publish --build-type mmi
- run:
name: Create GitHub release
command: .circleci/scripts/release-create-gh-release.sh
Expand Down
4 changes: 0 additions & 4 deletions .circleci/scripts/release-create-gh-release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ if [[ $current_commit_msg =~ Version[-[:space:]](v[[:digit:]]+.[[:digit:]]+.[[:d
then
tag="${BASH_REMATCH[1]}"
flask_version="$(print_build_version 'flask')"
mmi_version="$(print_build_version 'mmi')"

install_github_cli

Expand All @@ -72,15 +71,12 @@ then
--attach builds-mv2/metamask-firefox-*.zip \
--attach builds-flask/metamask-flask-chrome-*.zip \
--attach builds-flask-mv2/metamask-flask-firefox-*.zip \
--attach builds-mmi/metamask-mmi-chrome-*.zip \
--attach builds-mmi/metamask-mmi-firefox-*.zip \
--message "Version ${tag##v}" \
--message "$release_body" \
--commitish "$CIRCLE_SHA1" \
"$tag"

publish_tag 'Flask' "${flask_version}"
publish_tag 'MMI' "${mmi_version}"
else
printf '%s\n' 'Version not found in commit message; skipping GitHub Release'
exit 0
Expand Down

0 comments on commit 3fe78b1

Please sign in to comment.