Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regex match condition for primary type #353

Merged
merged 6 commits into from
Dec 19, 2024
Merged

fix: regex match condition for primary type #353

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
98183e7
Fix primary type regex match condition for types signatures
jpuri Dec 19, 2024
5fdeecd
update
jpuri Dec 19, 2024
6e7f957
update
jpuri Dec 19, 2024
e67fa81
update
jpuri Dec 19, 2024
8e04103
Update src/utils/common.test.ts
jpuri Dec 19, 2024
c3551cd
Merge branch 'main' into correct_condition
jpuri Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/utils/common.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ describe('CommonUtils', () => {
it('return types which are not array without any change', () => {
expect(stripArrayTypeIfPresent('string')).toBe('string');
expect(stripArrayTypeIfPresent('string []')).toBe('string []');
expect(
stripArrayTypeIfPresent(undefined as unknown as string),
jpuri marked this conversation as resolved.
Show resolved Hide resolved
).toBeUndefined();
});
});
});
2 changes: 1 addition & 1 deletion src/utils/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* @returns Parameter string with array brackets [] removed.
*/
export const stripArrayTypeIfPresent = (typeString: string) => {
if (typeString?.match(/\S\[\d*\]$/u) !== null) {
if (typeString?.match(/\S\[\d*\]$/u)) {
Gudahtt marked this conversation as resolved.
Show resolved Hide resolved
return typeString.replace(/\[\d*\]$/gu, '').trim();
}
return typeString;
Expand Down
Loading