15.1.0 #352
Merged
15.1.0 #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Gudahtt
reviewed
Dec 18, 2024
CHANGELOG.md
Outdated
| @@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ## [15.1.0] | |||
| ### Changed | |||
| - fix: Add validation for types sign message primary type ([#350](https://github.com/MetaMask/eth-json-rpc-middleware/pull/350)) | |||
There was a problem hiding this comment.
This is a breaking change, right? We're throwing errors in this middleware in cases we weren't previously. There was no way the signature would actually work in those cases though, so maybe this is fine to categorize as non-breaking 🤔
There was a problem hiding this comment.
Could you improve the change entry? The fix: prefix is confusing given that this is under the "Changed" category, and is a minor bump (which suggests that this is not just a bug fix).
Maybe we can describe this as "Improved validation of primary type for signTypedDataV3 and signTypedDataV4"
There was a problem hiding this comment.
Sounds good, I updated the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the release candidate for version 15.1.0.