Replace withAppKeyOrigin option with getAppKey
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new `getAppKey` method will return the private app key derived from the provided origin. This serves as an alternative to optionally augmenting each keyring method with a set of options that may contain a `withAppKeyOrigin` value. Moving app key generation to a single place makes it easier to limit access to sensitive information, such as the primary private keys. It also allows the consumer to use app keys more efficiently by using the same wallet for successive operations, rather than generating a new private key each time with `keccak`. The private app key returned can itself be used to instantiate a new keyring instance, which allows app keys to perform all the same functions that a 'normal' key would allow.
|
This depends upon MetaMask/eth-simple-keyring#35 , and upon v4.0.0 of |
|
I will bump the version to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
getAppKeymethod will return the private app key derived from the provided origin. This serves as an alternative to optionally augmenting each keyring method with a set of options that may contain awithAppKeyOriginvalue.Moving app key generation to a single place makes it easier to limit access to sensitive information, such as the primary private keys. It also allows the consumer to use app keys more efficiently by using the same wallet for successive operations, rather than generating a new private key each time with
keccak.The private app key returned can itself be used to instantiate a new keyring instance, which allows app keys to perform all the same functions that a 'normal' key would allow.