omit empty params in eth_blockNumber call

MetaMask · Nov 24, 2023 · 792d2ed · 792d2ed
1 parent a33cffa
commit 792d2ed
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/src/PollingBlockTracker.test.ts b/src/PollingBlockTracker.test.ts
@@ -206,7 +206,6 @@ describe('PollingBlockTracker', () => {
               jsonrpc: '2.0' as const,
               id: expect.any(Number),
               method: 'eth_blockNumber' as const,
-              params: [],
               skipCache: true,
             },
             expect.any(Function),
@@ -740,7 +739,6 @@ describe('PollingBlockTracker', () => {
               jsonrpc: '2.0' as const,
               id: expect.any(Number),
               method: 'eth_blockNumber' as const,
-              params: [],
               skipCache: true,
             },
             expect.any(Function),
@@ -1257,7 +1255,6 @@ describe('PollingBlockTracker', () => {
                   jsonrpc: '2.0' as const,
                   id: expect.any(Number),
                   method: 'eth_blockNumber' as const,
-                  params: [],
                   skipCache: true,
                 },
                 expect.any(Function),
@@ -2018,7 +2015,6 @@ describe('PollingBlockTracker', () => {
                   jsonrpc: '2.0' as const,
                   id: expect.any(Number),
                   method: 'eth_blockNumber' as const,
-                  params: [],
                   skipCache: true,
                 },
                 expect.any(Function),

diff --git a/src/PollingBlockTracker.ts b/src/PollingBlockTracker.ts
@@ -1,6 +1,6 @@
 import type { SafeEventEmitterProvider } from '@metamask/eth-json-rpc-provider';
 import SafeEventEmitter from '@metamask/safe-event-emitter';
-import type { JsonRpcRequest } from '@metamask/utils';
+import type { Json, JsonRpcRequest } from '@metamask/utils';
 import getCreateRandomId from 'json-rpc-random-id';
 import pify from 'pify';
 
@@ -287,7 +287,6 @@ export class PollingBlockTracker
       jsonrpc: '2.0',
       id: createRandomId(),
       method: 'eth_blockNumber',
-      params: [],
     };
     if (this._setSkipCacheFlag) {
       req.skipCache = true;