Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable function expressions again #258

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Nov 17, 2022

The FunctionExpression selector apparently applies to class methods too, so the following would result in an error:

class Foo {
  bar() { }
}

I've removed this from the no-restricted-syntax rule to allow class methods again.

@Mrtenz Mrtenz requested a review from a team as a code owner November 17, 2022 12:40
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mrtenz Mrtenz force-pushed the mrtenz/enable-function-expressions branch from 400b9aa to 8eabff1 Compare November 17, 2022 13:44
@Mrtenz Mrtenz merged commit 2e9c268 into main Nov 17, 2022
@Mrtenz Mrtenz deleted the mrtenz/enable-function-expressions branch November 17, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants