Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Update @typescript-eslint parser and plugin #230

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Aug 13, 2022

BREAKING: The packages @typescript-eslint/parser and @typescript-eslint/plugin have been updated from v4 to v5.

We are affected only by the changes to the recommended configuration. The rule @typescript-eslint/explicit-module-boundary-types is no longer recommended, so we don't have to explicitly disable it anymore. There are two new recommended rules: @typescript-eslint/no-loss-of-precision and @typescript-eslint/no-unnecessary-type-constraint.

Both of these new rules seem useful, so they have been left enabled.

The packages `@typescript-eslint/parser` and
`@typescript-eslint/plugin` have been updated from v4 to v5.

We are affected only by the changes to the recommended configuration.
The rule `@typescript-eslint/explicit-module-boundary-types` is no
longer recommended, so we don't have to explicitly disable it anymore.
There are two new recommended rules:
`@typescript-eslint/no-loss-of-precision` [1] and
`@typescript-eslint/no-unnecessary-type-constraint` [2].

Both of these new rules seem useful, so they have been left enabled.

[1]: https://typescript-eslint.io/rules/no-loss-of-precision
[2]: https://typescript-eslint.io/rules/no-unnecessary-type-constraint
@Gudahtt Gudahtt force-pushed the update-typescript-eslint-parser-and-plugin branch from c086d8d to 78e2319 Compare August 13, 2022 20:15
@Gudahtt Gudahtt changed the title Update @typescript-eslint parser and plugin BREAKING: Update @typescript-eslint parser and plugin Aug 13, 2022
@Gudahtt Gudahtt marked this pull request as ready for review August 13, 2022 20:16
@Gudahtt Gudahtt requested a review from a team as a code owner August 13, 2022 20:16
Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm and are inline with what was done on the extension repo.

@Gudahtt Gudahtt merged commit 7023c31 into main Aug 15, 2022
@Gudahtt Gudahtt deleted the update-typescript-eslint-parser-and-plugin branch August 15, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants