Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update execa #121

Merged
merged 7 commits into from
Dec 8, 2023
Merged

Update execa #121

merged 7 commits into from
Dec 8, 2023

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Dec 6, 2023

This PR updates execa to ^8.0.1. Since execa@>=6.0.0 is ESM-only and jest only has experimental ESM support (jestjs/jest#10976), this required switching from ts-jest to babel-jest. To minimize dependency transpilation, the ESM packages that are necessary to transpile are enumerated in jest.config.js.

This version of execa includes automatic escaping of shell arguments, which was the entire point of #112, #113, and this PR.

The state of ESM support in the Node.js ecosystem is absolutely horrible, and I would not recommend further migrations for the time being. We should continue to dual-release our packages and avoid ESM-only dependencies until the ecosystem has matured. For details see the above jest issue and nodejs/node#37648.

Copy link

socket-security bot commented Dec 6, 2023

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
execa 8.0.1 None +8 167 kB ehmicky

🚮 Removed packages: ts-jest@29.1.1

Copy link

socket-security bot commented Dec 6, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: get-stream@8.0.1

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@rekmarks
Copy link
Member Author

rekmarks commented Dec 7, 2023

@SocketSecurity ignore get-stream@8.0.1

The new author appears to be a chosen collaborator of sindresorhus, who still owns the repo and the package.

@rekmarks rekmarks marked this pull request as ready for review December 8, 2023 17:54
@rekmarks rekmarks requested a review from a team as a code owner December 8, 2023 17:54
@rekmarks rekmarks merged commit f969b0e into main Dec 8, 2023
16 checks passed
@rekmarks rekmarks deleted the execa-update branch December 8, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants