-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update execa #121
Update execa #121
Conversation
16810c6
to
7ac0338
Compare
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: ts-jest@29.1.1 |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@SocketSecurity ignore get-stream@8.0.1 The new author appears to be a chosen collaborator of |
d574145
to
6860375
Compare
This PR updates
execa
to^8.0.1
. Sinceexeca@>=6.0.0
is ESM-only andjest
only has experimental ESM support (jestjs/jest#10976), this required switching fromts-jest
tobabel-jest
. To minimize dependency transpilation, the ESM packages that are necessary to transpile are enumerated injest.config.js
.This version of
execa
includes automatic escaping of shell arguments, which was the entire point of #112, #113, and this PR.The state of ESM support in the Node.js ecosystem is absolutely horrible, and I would not recommend further migrations for the time being. We should continue to dual-release our packages and avoid ESM-only dependencies until the ecosystem has matured. For details see the above
jest
issue and nodejs/node#37648.