feat: move and export notification isVersionInBounds util #6793
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Allows clients to also consume and use this util to reduce further duplication (e.g. carousels)
References
https://consensyssoftware.atlassian.net/browse/ASSETS-1362
Checklist
Note
Adds and exports
isVersionInBounds
and refactors feature announcement version filtering to use it, with tests and changelog update.utils/isVersionInBounds
to validate versions within exclusive min/max bounds.services/feature-announcements.ts
):isVersionInBounds
.semver
gt/lt
usage in this file.NotificationServicesController/index.ts
):isVersionInBounds
from package root.utils/isVersionInBounds.test.ts
covering min, max, and combined bounds cases.Written by Cursor Bugbot for commit 0e1de71. This will update automatically on new commits. Configure here.