Skip to content

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Oct 7, 2025

Explanation

Allows clients to also consume and use this util to reduce further duplication (e.g. carousels)

References

https://consensyssoftware.atlassian.net/browse/ASSETS-1362

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Adds and exports isVersionInBounds and refactors feature announcement version filtering to use it, with tests and changelog update.

  • Utilities:
    • Add utils/isVersionInBounds to validate versions within exclusive min/max bounds.
  • Feature Announcements Service (services/feature-announcements.ts):
    • Replace inline semver filtering with isVersionInBounds.
    • Remove direct semver gt/lt usage in this file.
  • Exports (NotificationServicesController/index.ts):
    • Export isVersionInBounds from package root.
  • Tests:
    • Add utils/isVersionInBounds.test.ts covering min, max, and combined bounds cases.
  • Changelog:
    • Note new exported util under Unreleased.

Written by Cursor Bugbot for commit 0e1de71. This will update automatically on new commits. Configure here.

allows clients to also consume and use this util to reduce further duplication
@Prithpal-Sooriya Prithpal-Sooriya force-pushed the ASSETS-1362/export-is-version-in-bounds-check branch from f3291fd to 0fe68da Compare October 7, 2025 16:45
@Prithpal-Sooriya Prithpal-Sooriya marked this pull request as ready for review October 7, 2025 16:45
@Prithpal-Sooriya Prithpal-Sooriya requested review from a team as code owners October 7, 2025 16:45
Copy link
Member

@juanmigdr juanmigdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Prithpal-Sooriya Prithpal-Sooriya enabled auto-merge (squash) October 8, 2025 13:24
@Prithpal-Sooriya Prithpal-Sooriya merged commit f526ee0 into main Oct 8, 2025
243 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the ASSETS-1362/export-is-version-in-bounds-check branch October 8, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants