Skip init if coverage id is available #6792
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Currently the Shield Controller calls the
/init
endpoint every time a coverage request is made.This PR implements an optimization where the
/init
endpoint is skipped if the coverage Id is already available.References
Checklist
Note
Coverage checks now accept a request object with optional coverageId to skip /init; controller, backend, types, tests, and changelog updated accordingly.
ShieldBackend
to accept request objects:checkCoverage({ txMeta, coverageId? })
,checkSignatureCoverage({ signatureRequest, coverageId? })
with new typesCheckCoverageRequest
andCheckSignatureCoverageRequest
.CHANGELOG.md
: note breaking change forcheckCoverage
.src/backend.ts
):ShieldRemoteBackend
skipsv1/*/coverage/init
whencoverageId
is provided; otherwise performs init then polls result.src/ShieldController.ts
):coverageId
via#getLatestCoverageId
tocheckCoverage
andcheckSignatureCoverage
to enable init-skip.setupCoverageResultReceived
helper; adjust simulation flow and mocks (e.g.,MOCK_COVERAGE_ID
).Written by Cursor Bugbot for commit d24e5e6. This will update automatically on new commits. Configure here.