Skip to content

Conversation

ulissesferreira
Copy link
Contributor

@ulissesferreira ulissesferreira commented Oct 1, 2025

Explanation

As we move towards the new Account Provider model we must not forget to include Bitcoin and Tron support. These changes are essential to have their accounts automatically discovered on the MetaMask Extension for example.

References

Tron Epic: https://consensyssoftware.atlassian.net/browse/NWNT-410?atlOrigin=eyJpIjoiY2Y5ZjYzYmU1MjBhNGZjNmI3NGE5MGZjMTI1ZDA0ZjciLCJwIjoiaiJ9

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Registers BtcAccountProvider and TrxAccountProvider in MultichainAccountService, wires their configs, and updates tests to mock and validate them.

  • MultichainAccountService:
    • Register BtcAccountProvider and TrxAccountProvider alongside existing EvmAccountProvider and SolAccountProvider using AccountProviderWrapper.
    • Extend providerConfigs to accept BtcAccountProvider and TrxAccountProvider configs.
    • Update imports to source providers and types from ./providers.
  • Tests (MultichainAccountService.test.ts):
    • Mock BtcAccountProvider and TrxAccountProvider; extend Mocks to include them.
    • Set static NAME constants for BTC/TRX providers in setup.
    • Add mockAccountProvider calls for BTC (BtcAccountType.P2wpkh) and TRX (TrxAccountType.Eoa).
    • Verify provider config forwarding for BTC/TRX and optional config behavior.

Written by Cursor Bugbot for commit b0bad50. This will update automatically on new commits. Configure here.

@ulissesferreira ulissesferreira requested a review from a team as a code owner October 1, 2025 12:56
@ulissesferreira ulissesferreira force-pushed the feat/bitcoin-and-tron-bip44-support branch 2 times, most recently from 501f465 to 20e0f76 Compare October 7, 2025 09:37
@ulissesferreira ulissesferreira force-pushed the feat/bitcoin-and-tron-bip44-support branch from 20e0f76 to b0bad50 Compare October 7, 2025 09:45
Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejecting for now, as we don't want to use those providers without any feature flags for the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants