refactor: use new @metamask/keyring-api layout (split packages)
#4695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
ccharly
force-pushed
the
refactor/use-new-accounts-packages
branch
2 times, most recently
from
1fa68fc to
611dd20
Compare
ccharly
force-pushed
the
refactor/use-new-accounts-packages
branch
4 times, most recently
from
44e5b9d to
105f978
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
ccharly
force-pushed
the
refactor/use-new-accounts-packages
branch
2 times, most recently
from
44af2e0 to
8839575
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
ccharly
force-pushed
the
refactor/use-new-accounts-packages
branch
from
8839575 to
e0cafc3
Compare
ccharly
force-pushed
the
refactor/use-new-accounts-packages
branch
2 times, most recently
from
bea7ef9 to
a744f8f
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
ccharly
changed the title
@metamask/keyring-api layout (split packages)
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
4 tasks
Prithpal-Sooriya
approved these changes
Dec 11, 2024
sahar-fehri
approved these changes
Dec 11, 2024
gantunesr
approved these changes
Dec 11, 2024
4 tasks
ccharly
added a commit
that referenced
this pull request
Dec 11, 2024
## Explanation This peer dependency has been wrongly removed with my previous PR. I'm just re-adding it. ## References - #4695 ## Changelog N/A (will be unchanged for the next release) ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
keyring-apihas been split out into multiple smaller packages, this introduce some breaking changes since some exports have been moved elsewhere.This was done to reduce the number of required dependencies for the
keyring-api. TheInternalAccounttype (widely used internally by some controllers) has been moved to a new package:@metamask/keyring-internal-api.References
Relates to:
Basic testing done through the CI + preview builds:
@metamask/keyring-apilayout (split packages) metamask-extension#28861Changelog
@metamask/keyring-controller@metamask/providers@metamask/keyring-apito^12.0.0@metamask/keyring-internal-api@^1.0.0@metamask/accounts-controller@metamask/keyring-apito^12.0.0@metamask/eth-snap-keyringto^7.0.0@metamask/keyring-internal-api@^1.0.0@metamask/assets-controllers@metamask/keyring-api@metamask/keyring-internal-api@^1.0.0@metamask/chain-controller@metamask/keyring-api@metamask/keyring-internal-api@^1.0.0@metamask/keyring-utils@^1.0.0@metamask/profile-sync-controller@metamask/keyring-api@metamask/keyring-internal-api@^1.0.0Checklist