Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gas-fee-controller): add missing @metamask/polling-controller #1748

Merged
merged 3 commits into from
Oct 2, 2023
Merged

fix(gas-fee-controller): add missing @metamask/polling-controller #1748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46d975f
fix(gas-fee-controller): add missing @metamask/polling-controller
legobeat Oct 2, 2023
fb4260a
add exception for polling-controller peer depenency enforcement
adonesky1 Oct 2, 2023
3db5cea
Merge branch 'main' into deps-gas-controller-add-polling-controller
adonesky1 Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions constraints.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,14 +298,15 @@ gen_enforced_dependency(WorkspaceCwd, DependencyIdent, null, DependencyType) :-
workspace_has_dependency(WorkspaceCwd, DependencyIdent, DependencyRange, DependencyType),
DependencyType == 'devDependencies'.

% If a controller dependency (other than `base-controller` and
% `eth-keyring-controller`) is listed under "dependencies", it should also be
% If a controller dependency (other than `base-controller`, `eth-keyring-controller` and
% `polling-controller`) is listed under "dependencies", it should also be
% listed under "peerDependencies". Each controller is a singleton, so we need
% to ensure the versions used match expectations.
gen_enforced_dependency(WorkspaceCwd, DependencyIdent, DependencyRange, 'peerDependencies') :-
workspace_has_dependency(WorkspaceCwd, DependencyIdent, DependencyRange, 'dependencies'),
DependencyIdent \= '@metamask/base-controller',
DependencyIdent \= '@metamask/eth-keyring-controller',
DependencyIdent \= '@metamask/polling-controller',
is_controller(DependencyIdent).

% All packages must specify a minimum Node version of 16.
Expand Down
1 change: 1 addition & 0 deletions packages/gas-fee-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
"@metamask/controller-utils": "^5.0.1",
"@metamask/eth-query": "^3.0.1",
"@metamask/network-controller": "^13.0.1",
"@metamask/polling-controller": "^0.0.0",
"@metamask/utils": "^8.1.0",
"@types/uuid": "^8.3.0",
"ethereumjs-util": "^7.0.10",
Expand Down
3 changes: 2 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1807,6 +1807,7 @@ __metadata:
"@metamask/controller-utils": ^5.0.1
"@metamask/eth-query": ^3.0.1
"@metamask/network-controller": ^13.0.1
"@metamask/polling-controller": ^0.0.0
"@metamask/utils": ^8.1.0
"@types/jest": ^27.4.1
"@types/jest-when": ^2.7.3
Expand Down Expand Up @@ -2120,7 +2121,7 @@ __metadata:
languageName: unknown
linkType: soft

"@metamask/polling-controller@workspace:packages/polling-controller":
"@metamask/polling-controller@^0.0.0, @metamask/polling-controller@workspace:packages/polling-controller":
version: 0.0.0-use.local
resolution: "@metamask/polling-controller@workspace:packages/polling-controller"
dependencies:
Expand Down
Loading