[transaction-controller] Boundless growth of transaction history

[Gudahtt]

Each transaction has a history property, which tracks changes to the transaction state. This history doesn't currently have a maximum limit and can grow indefinitely, effectively becoming a memory leak. Unfortunately it can grow rather rapidly as well, because it tracks changes to the transaction warning.error state which can update multiple times in a single pending transaction status check.

We should prevent this history from growing unbounded, and maybe replace or severely limit its size in general.

[Gudahtt]

In one report of this happening, there was a loop of these two updates:

[
  {
    value: '[ethjs-rpc] rpc error with payload {"id":[number],"jsonrpc":"2.0","params":["0x"],"method":"eth_getTransactionReceipt"} { "code": -32603, "message": "Internal JSON-RPC error.", "data": { "code": -32602, "message": "invalid argument 0: hex string has length 0, want 64 for common.Hash", "cause": null }, "stack": ...'
    path: '/warning/error',
    op: 'replace'
  },
  {
    note: 'transactions/pending-tx-tracker#event: tx:warning',
    value: 'There was a problem loading this transaction.',
    path: '/warning/message',
    op: 'replace'
  },
]

In this case it was encountered with a Ledger account, though I'm not sure whether that's relevant.

[Gudahtt]

Trimming this down is tricky because we use the transaction history in the UI.

It was originally added as diagnostic data, but we began using it for the "Transaction activity" view, for example here: https://github.com/MetaMask/metamask-extension/blob/be1c107fd323112a6677e05e2714b6602c4367ab/ui/components/app/transaction-activity-log/transaction-activity-log.util.js#L76 (this is the one example I could find quickly, not sure if there are others).

[Gudahtt]

Here is the related extension issue: MetaMask/metamask-extension#9372