Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and improve clarity in documentation files #120

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

Dimitrolito
Copy link
Contributor

This pull request addresses several minor typos and grammatical issues in multiple documentation files:

  1. Fixed incorrect use of "a" instead of "an" in the "migrations-guidelines.md" file.
  2. Corrected the hyphenation of "up to date" in the "pull-requests.md" file.
  3. Corrected the article usage ("a" to "an") in the "extension-e2e-guidelines.md" file.

These changes enhance the clarity and correctness of the documentation.

Issue(s) Fixed:

No specific issue fixed, general documentation improvement.

Preview:

Link to the preview (if applicable)

Checklist:

  • Reviewed and approved by a team member.
  • Changes adhere to the contributing guidelines.

@Dimitrolito Dimitrolito requested a review from a team as a code owner December 9, 2024 15:18
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@@ -50,7 +50,7 @@ If there are specific changes within your pull request that you'd like to call y

### Create smaller pull requests

Large pull requests are extremely painful to review. They also need to be kept up to date more frequently since they have a higher chance of creating conflicts that need to be resolved, and they make the commit history more difficult to understand after they are merged.
Large pull requests are extremely painful to review. They also need to be kept up-to-date more frequently since they have a higher chance of creating conflicts that need to be resolved, and they make the commit history more difficult to understand after they are merged.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prosodically, it sounds like it ought to be "up to date". The internet is divided over this one, but grammatically I think you might be correct.

@mcmire mcmire merged commit 63d5d17 into MetaMask:main Dec 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants