Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BAG token #1346

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Add support for BAG token #1346

merged 6 commits into from
Oct 3, 2024

Conversation

Garchbold
Copy link
Contributor

No description provided.

@Garchbold Garchbold requested review from MRabenda and a team as code owners August 21, 2024 19:07
@MRabenda
Copy link
Collaborator

Hey, before We would be able to merge it - I would like to improve icon quality:

  1. Your image currently has some significant padding - do you want to have it?
  2. Regular SVG logo like yours should be <15kB - current one is over 150kB, would you be able to work on better SVG image?

@Garchbold
Copy link
Contributor Author

@MRabenda thanks for the followup, we were able to get it down ~25kb, is that sufficient. This is the smallest we could get it while keeping the colors intact.

@MRabenda
Copy link
Collaborator

MRabenda commented Sep 9, 2024

Hey, sorry @Garchbold but in the code of the image we can find

</clipPath> <image id="image0_1387_4858" width="375" height="375" xlink:href="data:image/png;base64,iVBORw0KGgoAA....

This is actually still PNG raster image instead of SVG vector one

@Garchbold
Copy link
Contributor Author

Hey @MRabenda just checking in again is there still an outstanding issue for this pr?

@MRabenda
Copy link
Collaborator

I would be able to merge it with proper vector image, not a PNG saved as SVG

@Garchbold
Copy link
Contributor Author

is 70 kB sufficient, after switching it to a proper vector image thats the size that we end up at

@MRabenda
Copy link
Collaborator

If is a full vector that should be fine, please update it

@Garchbold
Copy link
Contributor Author

Hey @MRabenda just updated, please let me know if that works, thank you

MRabenda
MRabenda previously approved these changes Sep 27, 2024
@MRabenda
Copy link
Collaborator

Hey,

Icon looks good - last missing element is that address should be in EIP-55 format - the correct one would look like 0x808688c820AB080A6Ff1019F03E5EC227D9b522B

@Garchbold
Copy link
Contributor Author

Thanks for all the patience @MRabenda it should be ready now

@MRabenda MRabenda merged commit f228e6b into MetaMask:master Oct 3, 2024
7 checks passed
@b4u5
Copy link

b4u5 commented Oct 4, 2024

when could we expect this to be reflected in prod?

@Garchbold
Copy link
Contributor Author

Garchbold commented Oct 7, 2024

Hey @MRabenda

We are still seeing the incorrect image in metamask on polygon, is there a another repo we need to fork for the image to show up there?

Screenshot 2024-10-08 at 11 18 52 AM
Screenshot 2024-10-08 at 11 20 23 AM

@sahar-fehri
Copy link

Hello @Garchbold 👋
Could you check now if the contract on polygon 0x73b29199a8e4c146e893eb95f18dac41738a88c6 has the right icon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants