Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐱 add support for MEOW ERC20 token icon #1291

Merged
merged 2 commits into from
Apr 8, 2024
Merged

🐱 add support for MEOW ERC20 token icon #1291

merged 2 commits into from
Apr 8, 2024

Conversation

smolgroot
Copy link
Contributor

A PR to add the MEOW token icon.

You can also find our project here:

@smolgroot smolgroot requested review from MRabenda and a team as code owners March 27, 2024 21:41
MRabenda
MRabenda requested changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@MRabenda MRabenda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Based on the current contract state I can read that this contract decimals i 9 not 18
  2. Is there any chance that this 1MB logo would be optimized at any scale? Even few % would be nice

@smolgroot
Copy link
Contributor Author

OK, good point regarding the decimals..
I'm waiting for an optimized logo, I'll push it ASAP.

Thanks

@smolgroot
Copy link
Contributor Author

I've just added an optimized SVG logo and have corrected the contract decimal properly.

@MRabenda
Copy link
Collaborator

MRabenda commented Apr 8, 2024

Great work, thank you for your contribution

@MRabenda MRabenda merged commit 39c655e into MetaMask:master Apr 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MRabenda MRabenda MRabenda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smolgroot @MRabenda