Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ArkiTech to the contract-map.json #1263

Merged
merged 10 commits into from
Jan 16, 2024
Merged

Conversation

CraigArkiTechAi
Copy link
Contributor

@CraigArkiTechAi CraigArkiTechAi commented Dec 21, 2023

Add ArkiTech to the contract-map.json
Add logo to images folder (ARKI.SVG)

Contract address: 0xd3210F246Ae54C5a45A7b4A83315bf718F591bfc

Website: https://arkitech.ai

updated ARKI logo
Add ARKI token metadata
@CraigArkiTechAi CraigArkiTechAi requested review from MRabenda and a team as code owners December 21, 2023 17:52
@MRabenda
Copy link
Collaborator

Hey, svg image is required

@CraigArkiTechAi
Copy link
Contributor Author

Hey, svg image is required

will upload asap.

@CraigArkiTechAi
Copy link
Contributor Author

Hey, svg image is required

Please let me know if the quality is sufficient or not.

@MRabenda
Copy link
Collaborator

MRabenda commented Jan 2, 2024

Please update .png to .svg in JSON and remove PNG image from PR

@CraigArkiTechAi
Copy link
Contributor Author

Please update .png to .svg in JSON and remove PNG image from PR

Complete

@MRabenda
Copy link
Collaborator

MRabenda commented Jan 3, 2024

Last fast question - do you want to remove the padding from an icon on this is a correct representation of it? If sth I can help with that one

@CraigArkiTechAi
Copy link
Contributor Author

Last fast question - do you want to remove the padding from an icon on this is a correct representation of it? If sth I can help with that one

Yes if you could remove the padding I would appreciate it!

@MRabenda
Copy link
Collaborator

MRabenda commented Jan 3, 2024

During edit I realized that this image has over 4Mb - which is a lot. We are looking for light SVG for our clients - logo like this should be < 10 kB would you be able to create proper SVG image of small size with few vector paths?

@CraigArkiTechAi
Copy link
Contributor Author

During edit I realized that this image has over 4Mb - which is a lot. We are looking for light SVG for our clients - logo like this should be < 10 kB would you be able to create proper SVG image of small size with few vector paths?

Uploaded

@CraigArkiTechAi
Copy link
Contributor Author

Anything else needed?

@MRabenda
Copy link
Collaborator

Sorry @CraigArkiTechAi to say this but this image still does not satisfy requirements - what you posted in PNG encoded to SVG (inside a code we can find PNG file), which means this is not a vector version. I would still ask you to upload correct, small SVG as a vector version of the signet.

@CraigArkiTechAi
Copy link
Contributor Author

Sorry @CraigArkiTechAi to say this but this image still does not satisfy requirements - what you posted in PNG encoded to SVG (inside a code we can find PNG file), which means this is not a vector version. I would still ask you to upload correct, small SVG as a vector version of the signet.

not a problem i hired someone else, should be done tomorrow, thanks for your patience!

@CraigArkiTechAi
Copy link
Contributor Author

Sorry @CraigArkiTechAi to say this but this image still does not satisfy requirements - what you posted in PNG encoded to SVG (inside a code we can find PNG file), which means this is not a vector version. I would still ask you to upload correct, small SVG as a vector version of the signet.

Uploaded the new 4KB SVG, thanks!

@MRabenda
Copy link
Collaborator

Thanks for your contribution @CraigArkiTechAi

@MRabenda MRabenda merged commit 2bf6c85 into MetaMask:master Jan 16, 2024
5 checks passed
@CraigArkiTechAi
Copy link
Contributor Author

It looks like the full logo isn't fitting on the wallet, do I need to get the artist to resize?

@MRabenda

@MRabenda
Copy link
Collaborator

@CraigArkiTechAi can you post a screenshot of the wallet - what is the problem?

@CraigArkiTechAi
Copy link
Contributor Author

@CraigArkiTechAi can you post a screenshot of the wallet - what is the problem?

FireShot Capture 016 - MetaMask Portfolio - Token Detail - portfolio metamask io

The full logo is not fitting in the circle, the bottom corners are chopped off.

This is the same inside the wallet, but inside the wallet it has a grey background instead of white.

@MRabenda
Copy link
Collaborator

Yes, wallet uses rounded icons together with network marks. If you would like to change how it would be displayed please update image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants