Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Pantos Token #1217

Merged
merged 7 commits into from
Sep 13, 2023
Merged

Adding Pantos Token #1217

merged 7 commits into from
Sep 13, 2023

Conversation

jacekv
Copy link
Contributor

@jacekv jacekv commented Sep 6, 2023

Adding the Pantos Token with address and logo

@jacekv jacekv requested review from MRabenda and a team as code owners September 6, 2023 05:17
@MRabenda
Copy link
Collaborator

MRabenda commented Sep 6, 2023

  1. EIP-55 address format is required
  2. I would advice to have transparent background in SVG, it would be better handled in darkmode but it is optional

@jacekv
Copy link
Contributor Author

jacekv commented Sep 6, 2023

Git it. Let me fix that :)

Checksummed address
@jacekv
Copy link
Contributor Author

jacekv commented Sep 6, 2023

What do we do in the case of an overlapping symbol? Seems like there is another entry which has the same symbol as we do @MRabenda ?

@jacekv jacekv requested a review from MRabenda September 6, 2023 11:07
@MRabenda
Copy link
Collaborator

@jacekv After internal discussion - I removed that test, Can you rebase your PR with master? Then I should be able to merge it

@jacekv
Copy link
Contributor Author

jacekv commented Sep 12, 2023

Done :) I hope that it passes this time @MRabenda

@MRabenda MRabenda merged commit 99ea282 into MetaMask:master Sep 13, 2023
4 checks passed
@MRabenda
Copy link
Collaborator

Thanks @jacekv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants