Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release workflows #1071

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Add release workflows #1071

merged 3 commits into from
Aug 10, 2022

Conversation

rickycodes
Copy link
Member

@rickycodes rickycodes commented Aug 3, 2022

This is the bare minimum setup for automating npm releases in this repository.

This is a bit different since this doesn't have a build step so there's no need to build/cache.

It's also a bit different since this repo doesn't have a main branch so configuration has been changed slightly to use master

I've tested this out in my fork here:
https://github.com/rickycodes/contract-metadata/actions/runs/2790579879

closes: #1068

@rickycodes rickycodes requested review from MRabenda and a team as code owners August 3, 2022 15:33
@rickycodes rickycodes requested a review from Gudahtt August 3, 2022 15:33
@@ -0,0 +1,43 @@
name: Create Release Pull Request
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that this is slightly different from this version in the module template. Seems like this file is missing this section. https://github.com/MetaMask/metamask-module-template/blob/main/.github/workflows/create-release-pr.yml#L45. Any reason for this? Is this something we should remove from the module template?

Copy link
Member Author

@rickycodes rickycodes Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, interesting 🤔

that section doesn't appear to be present in MetaMask/controllers either? (that's what I used as the basis for this).

Copy link
Member Author

@rickycodes rickycodes Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcmire so it would appear that action-require-additional-reviewer which relies on this is currently broken per discussion in: MetaMask/action-require-additional-reviewer#44. In lieu of that, I don't think we should block on this (since it sounds like it'll likely go away anyway).

Copy link

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MRabenda MRabenda merged commit 80ed1a3 into master Aug 10, 2022
@MRabenda MRabenda deleted the add-release-workflows branch August 10, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup npm publishing
4 participants