-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release workflows #1071
Add release workflows #1071
Conversation
@@ -0,0 +1,43 @@ | |||
name: Create Release Pull Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice that this is slightly different from this version in the module template. Seems like this file is missing this section. https://github.com/MetaMask/metamask-module-template/blob/main/.github/workflows/create-release-pr.yml#L45. Any reason for this? Is this something we should remove from the module template?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh, interesting 🤔
that section doesn't appear to be present in MetaMask/controllers
either? (that's what I used as the basis for this).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcmire so it would appear that action-require-additional-reviewer
which relies on this is currently broken per discussion in: MetaMask/action-require-additional-reviewer#44. In lieu of that, I don't think we should block on this (since it sounds like it'll likely go away anyway).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This is the bare minimum setup for automating npm releases in this repository.
This is a bit different since this doesn't have a build step so there's no need to build/cache.
It's also a bit different since this repo doesn't have a
main
branch so configuration has been changed slightly to usemaster
I've tested this out in my fork here:
https://github.com/rickycodes/contract-metadata/actions/runs/2790579879
closes: #1068