Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing SVG icon for sETH and sUSD token #1050

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Conversation

KagamiChan
Copy link
Contributor

@KagamiChan KagamiChan commented May 19, 2022

This PR fixes token icon for sETH and sUSD.

An SVG XML should contain the ns information according to SVG standard here: https://www.w3.org/TR/SVG11/struct.html#NewDocumentOverview, which is saying:

In all cases, for compliance with the Namespaces in XML Recommendation [XML-NS], an SVG namespace declaration must be provided so that all SVG elements are identified as belonging to the SVG namespace.

Without this, the svg could not be recognized by some parsers and renderers, which might be problematic

Also I suggest we add some CI checks to make sure SVG icons are standard compliant

@KagamiChan KagamiChan requested review from MRabenda and a team as code owners May 19, 2022 16:04
@MRabenda MRabenda merged commit b00d6e5 into MetaMask:master Jul 6, 2022
@KagamiChan KagamiChan deleted the fix-svg branch July 14, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants