Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Privilege (PRVG) token #1048

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Add Privilege (PRVG) token #1048

merged 2 commits into from
Jun 23, 2022

Conversation

kthomas
Copy link
Contributor

@kthomas kthomas commented May 18, 2022

@kthomas kthomas requested review from MRabenda and a team as code owners May 18, 2022 07:09
contract-map.json Outdated Show resolved Hide resolved
@kthomas
Copy link
Contributor Author

kthomas commented Jun 21, 2022

@MRabenda thank you for looking at this for us. Most appreciated! The SVGs are compliant now.

@MRabenda
Copy link
Collaborator

@kthomas - this SVG https://github.com/MetaMask/contract-metadata/blob/34a584f1d1ecf6b2356e9e66861ee99d1f9aeed0/images/prvg.svg has over 300kB - regular one should be ~ 10kB are you able to decrease the size?

@kthomas kthomas force-pushed the add-prvg branch 2 times, most recently from c3edec5 to 35f644c Compare June 22, 2022 18:47
@kthomas
Copy link
Contributor Author

kthomas commented Jun 22, 2022

@kthomas - this SVG https://github.com/MetaMask/contract-metadata/blob/34a584f1d1ecf6b2356e9e66861ee99d1f9aeed0/images/prvg.svg has over 300kB - regular one should be ~ 10kB are you able to decrease the size?

@MRabenda 🤦🏻‍♂️ trust but verify eh? :)

It seems to have been able to be reduced down to 15k. Not sure why that was such a pita but seems within reason now.

Thanks 🍻

@kthomas
Copy link
Contributor Author

kthomas commented Jun 22, 2022

@MRabenda -- they got it down to 8k 🙏🏻

I guess that SVG is just ridiculous 🤷🏻

@MRabenda MRabenda merged commit 8ed2b0c into MetaMask:master Jun 23, 2022
@MRabenda
Copy link
Collaborator

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants