fix redundant WindowsDNS #1456
Merged
fix redundant WindowsDNS #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skyxim
reviewed
Aug 18, 2024
dns/system_windows.go
Outdated
| servers = append(servers, ip.String()) | ||
|
|
||
| ipStr := ip.String() | ||
| if !seenIPs[ipStr] { |
There was a problem hiding this comment.
Just store it in the map and get it from the map key. Map can be used as a set to store unique values, without having to judge once
|
These address would be unique after going through: Line 46 in d84f88b |
But |
Larvan2
added a commit
that referenced
this pull request
Aug 20, 2024
Co-authored-by: ForestL<45709305+forestl18@users.noreply.github.com>
Larvan2
added a commit
that referenced
this pull request
Aug 20, 2024
Co-authored-by: ForestL <45709305+forestl18@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
systemto get Windows system DNS, mihomo always get three same DNS. It's unnecessary and redundant, so just reserve unique one.