Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(listener/tproxy): possilly using released buffer in tproxy #1286

Merged
merged 1 commit into from
May 21, 2024
Merged

fix(listener/tproxy): possilly using released buffer in tproxy #1286

merged 1 commit into from
May 21, 2024

Conversation

5aaee9
Copy link

@5aaee9 5aaee9 commented May 21, 2024

tproxy panic randomly when running for a long time

@wwqgtxx
Copy link
Collaborator

wwqgtxx commented May 21, 2024

Don't you think you need an else branch? The previous logic was to ignore net.ErrClosed. After you modify it, it will return no matter what.

@5aaee9
Copy link
Author

5aaee9 commented May 21, 2024

Don't you think you need an else branch? The previous logic was to ignore net.ErrClosed. After you modify it, it will return no matter what.

Updated, I was got read: connection refused when tproxy, I previous think it might fine to stop read when read error.

@wwqgtxx wwqgtxx merged this pull request into MetaCubeX:Alpha May 21, 2024
wwqgtxx pushed a commit that referenced this pull request May 21, 2024
@5aaee9 @wwqgtxx
fix: possibly using released buffer in tproxy (#1286)
ac25061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@5aaee9 @wwqgtxx