Featue/psyneu 91 #57
Merged
Featue/psyneu 91 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afonsobspinto
requested changes
Jul 17, 2023
src/index.tsx
Outdated
| state.isSelection = false; | ||
|
|
||
| // Sets up the diagram engine | ||
| // By using useMemo, we ensure that the createEngine() function is only called when the component mounts, | ||
| // and the same engine instance is reused on subsequent re-renders. | ||
| const engine = useMemo(() => createEngine(), [metaNodes, metaLinks]); | ||
| const engine = useMemo(() => createEngine(), []); |
There was a problem hiding this comment.
Need to check with @ddelpiano if this change is allowed. I remember he added the metaNodes and metaLinks dependency for a reason related with the re-loading of a model
There was a problem hiding this comment.
good catch, and yes that is a problem.
afonsobspinto
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MetaPortModel and extend Link Factory to Application global props