Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/476 fix: undefined selectedTab #477

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

emekauja
Copy link
Contributor

fix for Error "undefined selectedTab should not happen" using enableDeleteWhenEmpty false as seen in #340

@SimaoBolota-MetaCell
Copy link

@emekauja

In the Visualize section of PsyNeuLinkView, the '+' icons and the tabs are not displayed, so I can't really test the fix properly.
If the user hovers over it seems like the elements are there, but not visible.
An example is provided below

Screen.Recording.2023-03-10.at.16.37.34.mov

To compare, using the development branch of geppetto-meta allows me to see the tabs and icons and move them around

Screen.Recording.2023-03-10.at.16.29.08.mov

@SimaoBolota-MetaCell
Copy link

@emekauja I tried what you suggested, adding the lines of code from this commit manually into development and running the application from there.

And the same is happening. The elements in the Visualize section are not visible.

image

image

If I go back to the original development version, the elements in the Visualize section appear as visible

image

image

cc @enicolasgomez @ddelpiano

@emekauja
Copy link
Contributor Author

I looked at this extensively and think we can skip this to the next release while i schedule a time to fix and look over this fix again, because if what we currently have in psyneulink is working as expected we should be able to skip till next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"undefined selectedTab should not happen" when adding tab to empty TabSet
2 participants