Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/707 #708

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Feature/707 #708

merged 2 commits into from
Sep 26, 2023

Conversation

filippomc
Copy link
Collaborator

@filippomc filippomc commented Sep 11, 2023

Closes #707

Implemented solution: the volume has been removed from the deployment

How to test this PR: set backups: true in the values-template.yaml and verify that the db-backups volume is not mounted to the database pod.

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • From the issue and the current PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • All the automated test checks are passing
  • All the linked issues are included in one milestone
  • All the linked issues are in the Review/QA column of the board
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

Nice to have (if relevant):

  • Screenshots of the changes
  • Explanatory video/animated gif

@filippomc filippomc marked this pull request as draft September 11, 2023 09:16
@filippomc filippomc marked this pull request as ready for review September 11, 2023 09:48
@filippomc filippomc merged commit 1d9aef6 into develop Sep 26, 2023
7 checks passed
@filippomc filippomc deleted the feature/707 branch September 26, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database backups volume shouldn't be mounted on the db pod
2 participants