Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with fast delete of field content #763

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

aranega
Copy link
Member

@aranega aranega commented Oct 18, 2023

When a field content is deleted too quickly (before the sync mechanism happens), an exception is raised in the Python side.
This behavior doesn't occur if you type a value in a field, wait a little bit that the sync happens, and delete it.
What's happening is that the code related to the netpyne field tries to delete a key that doesn't exists yet (see the video below).

issue-2023-10-18_02.31.38.mp4

The fix removes this behavior (see video below)

fix-2023-10-18_02.34.49.mp4

When a field content is deleted too quickly (before the sync mechanism
    happens), an exception is raised in the Python side.
This behavior doesn't occur if you type a value in a field, wait a
little bit that the sync happens, and delete it.
What's happening is that the code related to the netpyne field tries to
delete a key that doesn't exists yet (see the video below).

The fix removes this behavior (see video below)
@ddelpiano
Copy link
Member

all tests are failing here, @SimaoBolota-MetaCell @aranega could you sync to understand the problem please? Thx

@aranega
Copy link
Member Author

aranega commented Oct 31, 2023

@ddelpiano I think it's just a problem of sync with development, the original PR was done from the development branch where the release/1.0.0 wasn't merged yet.

EDIT> Nope, it seems that there is some selectors that are not working anymore for the tests. I'll try to debug that.

@aranega
Copy link
Member Author

aranega commented Oct 31, 2023

@ddelpiano After a small investivation, it looks like some ids in the CSS selectors for DOM elements are not found. In the first place, I thought it was because the tests where testing the master version of the code and not development, but I can see in the tests that they are directed towards the NetPyNE-UI test address, so they shouldn't fail. I'm continuing to search why it's happening.

EDIT> I didn't find exactly why the test are failing. They are for RxD_test and Save_Open. In the casse of the RxD_test, it seems that a menu that is supposed to be empty at some point in the test is not. Regarding the Save_Open, I really don't get why some ids are not found, perhaps it's something that I don't get from the logic of the test.

@SimaoBolota-MetaCell
Copy link
Contributor

Hi @ddelpiano @aranega
Thanks for the investigation @aranega
regarding the Save_Open Test, it is expected to fail due to this bug here https://metacell.atlassian.net/browse/NETPYNE-153
Regarding the RxD-test I'm checking it out, it might be just a threshold or something

@SimaoBolota-MetaCell
Copy link
Contributor

Fixed now!
@aranega @ddelpiano

@ddelpiano
Copy link
Member

@enicolasgomez could you please review this and merge if you are ok? Thanks!

@enicolasgomez enicolasgomez merged commit 6937f1b into development Nov 9, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants