prepare for atlas version 0.38.0 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twsearle
changed the title
s-good
reviewed
Jun 21, 2024
twsearle
force-pushed
the
feature/upgrade-atlas-version
branch
from
39b979b to
99de647
Compare
s-good
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Atlas at tag/0.38.0 will throw an error if a field is accessed where the fieldset contains multiple fields with the same name. This change fixes an error in the
Incrementclass that added multiple fields with the same name to the objects owned fieldset. As part of this change,Incrementcopy constructor will now perform a deep copy rather than a shallow copy.Issue(s) addressed
Partial fix for #98
Impact
None expected.
build groups
build-group=ecmwf/atlas#211
Checklist