-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add 1ob test #92
Conversation
@s-good this PR contains a test of the behaviour of the checkerboard partitioner. Once fixed, we ought to be able to remove the |
1b25003
to
b27a5f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks.
src/orca-jedi/geometry/Geometry.cc
Outdated
if ( ( (params_.partitioner.value() == "serial") || (comm.size() == 1) ) | ||
&& (halo > 0) ) { | ||
halo = 0; | ||
params_.sourceMeshHalo.set(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line doesn't work. I'm not sure what it should be, though.
This doesn't build for me: /home/h01/frwd/cylc-run/orca-jedi-92/share/mo-bundle/orca-jedi/src/orca-jedi/geometry/Geometry.cc: In constructor ‘orcamodel::Geometry::Geometry(const eckit::Configuration&, const eckit::mpi::Comm&)’: |
apologies both, I was using the CI to test the build as I could not get an interactive build to work on my local machine for this change. |
Description
Add ctests to cover the eORCA025 mesh and alter one of the observations so that it is on the boarder between the two tasks when MPI=2. This gives a failing test until we merge developments for
atlas-orca
so that we can add halos.Issue(s) addressed
Resolves #77
Part of #53
Dependencies
We should add the test without depending on the atlas orca change or any other change.
Impact
Expected impact on downstream repositories or workflows:
None
Checklist