Fixes to allow time interpolation #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use OOPS getvalues for time interpolation. This required two fixes:
* Use Configuration rather than Parameters for LocalIntepolator. We
ought to add support for Parameters to the OOPS Interpolator
interface at some point.
* State::read wasn't actually reading the state. This is necessary
for the psuedo-forecast to do anything at all
Update the test observations to enable a test of the time interpolation.
Update the hofx_odb_ice example and the ice test output following the
fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use OOPS getValues for time interpolation of the model background state. This required two fixes:
Also required:
Tests will fail unless nemo-feedback#15 is also merged at the same time as this pull request.