OOPS atlas changes

[twsearle]

Description

Changes associated with https://github.com/JCSDA-internal/oops/pull/2331 and the refactoring of the OOPS interface to atlas.

Issues

• fixes OOPS atlas interface updates #44

Testing

• mo-bundle build and run ctests (orca only)

[DJDavies2]

It seems that this branch doesn't actually work with https://github.com/JCSDA-internal/oops/pull/2331 after all, maybe something was committed to the oops branch after I tested? In any case I think this branch needs updating.

[DJDavies2]

Here is the compile failure:

/home/d03/frwd/cylc-run/orca-jedi-46/share/mo-bundle/orca-jedi/src/orca-jedi/variablechanges/VariableChange.h:36:3: note: no known conversion for argument 1 from 'const eckit::Configuration' to 'const Parameters_& {aka const VariableChangeParameters&}'
/home/d03/frwd/cylc-run/orca-jedi-46/share/mo-bundle/orca-jedi/src/orca-jedi/variablechanges/VariableChange.h:29:7: note: candidate: orcamodel::VariableChange::VariableChange(const orcamodel::VariableChange&)
class VariableChange: public util::Printable,
^~~~~~~~~~~~~~
/home/d03/frwd/cylc-run/orca-jedi-46/share/mo-bundle/orca-jedi/src/orca-jedi/variablechanges/VariableChange.h:29:7: note: candidate expects 1 argument, 2 provided
/home/d03/frwd/cylc-run/orca-jedi-46/share/mo-bundle/orca-jedi/src/orca-jedi/variablechanges/VariableChange.h:29:7: note: candidate: orcamodel::VariableChange::VariableChange(orcamodel::VariableChange&&)
/home/d03/frwd/cylc-run/orca-jedi-46/share/mo-bundle/orca-jedi/src/orca-jedi/variablechanges/VariableChange.h:29:7: note: candidate expects 1 argument, 2 provided
gmake[2]: *** [orca-jedi/src/mains/CMakeFiles/orcamodel_hofx3D.x.dir/orcamodelHofX3D.cc.o] Error 1
gmake[1]: *** [orca-jedi/src/mains/CMakeFiles/orcamodel_hofx3D.x.dir/all] Error 2
gmake[1]: *** Waiting for unfinished jobs....
gmake[2]: *** [orca-jedi/src/mains/CMakeFiles/orcamodel_hofx.x.dir/orcamodelHofX.cc.o] Error 1
gmake[1]: *** [orca-jedi/src/mains/CMakeFiles/orcamodel_hofx.x.dir/all] Error 2

[twsearle]

@DJDavies2 I think this is just because it was out-of-step with develop. I have merged and pushed again, but I am just going to squash and merge this now anyway as we have compile failures. I guess the underlying scheduled change went in?