Geometry API update #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss421
requested review from
twsearle,
yaswant,
DJDavies2,
KrissyRayD242 and
mo-joshuacolclough
twsearle
requested changes
Sep 29, 2022
DJDavies2
approved these changes
Sep 29, 2022
yaswant
approved these changes
Sep 30, 2022
mo-joshuacolclough
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
All passing, thanks 👍 BB suite output: http://fcm1/cylc-review/taskjobs/jcolclou/?suite=orcagrids_jcol_290922
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes broken build associated with missing functions that are now required due to https://github.com/JCSDA-internal/oops/pull/1913.
Adding two empty methods to satisfy the oops API calls.
@yaswant has independently tested this change and I'm still running BB but will later post output here.
Acceptance Criteria (Definition of Done)
Builds and runs ctests
Dependencies
None
Impact
None